[@types/braintree-web] Add some missing methods and properties from update to 3.69

[murphybob]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test YOUR_PACKAGE_NAME.)
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes:
  https://braintree.github.io/braintree-web/current/Client.html
  https://braintree.github.io/braintree-web/current/hosted-fields_index.js.html#line58

Note this is not an exhaustive update for 3.69, I don't have time I'm afraid. 🤷

[typescript-bot]

@murphybob Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• braintree-web on npm, on unpkg
  • owner-approval: @jbuckner

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Inactive

This PR has been inactive for 10 days — please merge or say something if there's a problem, otherwise it will move to the DT maintainer queue soon!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 49658,
  "author": "murphybob",
  "headCommitAbbrOid": "a33ecd3",
  "headCommitOid": "a33ecd33877c1fd8fc9d1ac695abf0bd6dfd1942",
  "lastPushDate": "2020-11-23T16:47:57.000Z",
  "lastActivityDate": "2020-12-15T16:36:46.000Z",
  "maintainerBlessed": false,
  "mergeOfferDate": "2020-12-05T04:29:18.000Z",
  "mergeRequestDate": "2020-12-15T16:36:46.000Z",
  "mergeRequestUser": "jbuckner",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "braintree-web",
      "kind": "edit",
      "files": [
        {
          "path": "types/braintree-web/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/braintree-web/modules/client.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/braintree-web/modules/hosted-fields.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/braintree-web/modules/three-d-secure.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/braintree-web/test/node.ts",
          "kind": "test"
        },
        {
          "path": "types/braintree-web/test/web.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "chlela",
        "jbuckner"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jbuckner",
      "date": "2020-12-05T04:28:40.000Z",
      "isMaintainer": false
    }
  ],
  "ciResult": "pass"
}

[typescript-bot]

🔔 @CHLELA @jbuckner — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[danger-public]

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

braintree-web (unpkg)

was missing the following properties:

1. localPayment
2. masterpass
3. paymentRequest
4. vaultManager
5. visaCheckout

as well as these 1 other properties...

preferredPaymentMethods

Generated by 🚫 dangerJS against a33ecd3

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

These typings are for a version of braintree-web that doesn’t yet exist on master, so I’ve compared them with v3.62.

	3.62@master	3.69 in #49658	diff
Batch compilation
Memory usage (MiB)	84.0	76.0	-9.5%
Type count	10399	10411	0%
Assignability cache size	3105	3106	0%
Language service
Samples taken	1463	1470	0%
Identifiers in tests	1463	1470	0%
getCompletionsAtPosition
Mean duration (ms)	362.1	370.6	+2.4%
Mean CV	9.7%	9.5%
Worst duration (ms)	450.8	565.7	+25.5% 🔸
Worst identifier	hostedFieldsInstance	container
getQuickInfoAtPosition
Mean duration (ms)	367.0	375.2	+2.2%
Mean CV	10.3%	10.0%
Worst duration (ms)	459.9	487.8	+6.0%
Worst identifier	addClass	select

Looks like there were a couple significant differences—take a look at worst-case duration for getting completions at a position to make sure everything looks ok.

[typescript-bot]

Updated numbers for you here from 66a9c7c.

These typings are for a version of braintree-web that doesn’t yet exist on master, so I’ve compared them with v3.62.

Comparison details 📊

	3.62@master	3.69 in #49658	diff
Batch compilation
Memory usage (MiB)	82.2	82.2	0.0%
Type count	10399	10413	0%
Assignability cache size	3105	3106	0%
Language service
Samples taken	1463	1470	0%
Identifiers in tests	1463	1470	0%
getCompletionsAtPosition
Mean duration (ms)	334.9	410.6	+22.6% 🔸
Mean CV	9.1%	13.3%
Worst duration (ms)	427.5	635.0	+48.6% 🔸
Worst identifier	my3DSContainer	container
getQuickInfoAtPosition
Mean duration (ms)	339.3	416.7	+22.8% 🔸
Mean CV	9.6%	13.6%
Worst duration (ms)	429.5	573.8	+33.6% 🔸
Worst identifier	clear	container

It looks like there are several metrics that changed quite a bit. You might want to take a look and make sure your changes won’t cause slow-downs for users consuming these types.

[ismaelmedinapacklink]

@murphybob you could include this doc for your last commit: https://braintree.github.io/braintree-web/current/HostedFields.html#on

[typescript-bot]

Re-ping @CHLELA, @jbuckner:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[jbuckner]

Nice job! Thank you for the updates!

[typescript-bot]

@murphybob Everything looks good here. Great job! I am ready to merge this PR (at a33ecd3) on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@CHLELA, @jbuckner: you can do this too.)

[typescript-bot]

Re-ping @murphybob / @CHLELA, @jbuckner:

This PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it in three weeks if this doesn't happen.

(Note that posting a comment will restart the month-timer again, so avoid doing that if you don't want me to nag you again... or you can just close it or turn it into a draft now.)

[jbuckner]

Ready to merge

[typescript-bot]

I just published @types/braintree-web@3.69.0 to npm.