Improvement so we can use the encoding without errors in an array.

[Rechdan]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: official docs

[typescript-bot]

@Rechdan Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• struct on npm, on unpkg
  • owner-approval: @benallfree

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 50556,
  "author": "Rechdan",
  "headCommitOid": "dfcdf7c6344070dc1e4a5b7dd4e9e12dd8528258",
  "lastPushDate": "2021-01-12T16:50:37.000Z",
  "lastActivityDate": "2021-01-12T18:26:11.000Z",
  "maintainerBlessed": false,
  "mergeOfferDate": "2021-01-12T17:51:38.000Z",
  "mergeRequestDate": "2021-01-12T18:26:11.000Z",
  "mergeRequestUser": "Rechdan",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "struct",
      "kind": "edit",
      "files": [
        {
          "path": "types/struct/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/struct/struct-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "benallfree"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "benallfree",
      "date": "2021-01-12T17:51:02.000Z",
      "isMaintainer": false
    }
  ],
  "ciResult": "pass"
}

[typescript-bot]

🔔 @benallfree — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@Rechdan The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#50556	diff
Batch compilation
Memory usage (MiB)	75.5	72.6	-3.8%
Type count	9389	9394	0%
Assignability cache size	1824	1823	0%
Language service
Samples taken	45	52	+16%
Identifiers in tests	45	52	+16%
getCompletionsAtPosition
Mean duration (ms)	323.4	323.3	0.0%
Mean CV	13.6%	13.2%
Worst duration (ms)	407.1	403.3	-0.9%
Worst identifier	allocate	array
getQuickInfoAtPosition
Mean duration (ms)	313.4	316.7	+1.1%
Mean CV	12.7%	12.3%
Worst duration (ms)	379.8	411.7	+8.4%
Worst identifier	Struct	cstruct

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[benallfree]

You're back for more. Thank you!

[typescript-bot]

@Rechdan Everything looks good here. Great job! I am ready to merge this PR (at dfcdf7c) on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@benallfree: you can do this too.)

[Rechdan]

Ready to merge

[typescript-bot]

I just published @types/struct@0.0.3 to npm.