jsdom: deprecate TS 3.3

[sandersn]

TS 3.3 is no longer supported on Definitely Typed.

This PR merges the contents of ts3.3/index.d.ts into ts3.4/index.d.ts; the latter previously included the former and used interface merging to add one new property.

[typescript-bot]

@sandersn Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• jsdom on npm, on unpkg

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ❌ Most recent commit is approved by type definition owners or DT maintainers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 50559,
  "author": "sandersn",
  "headCommitOid": "b977d45b1d35ea38da1e5f870017ea893edb12ef",
  "lastPushDate": "2021-01-12T17:12:38.000Z",
  "lastActivityDate": "2021-01-12T17:13:37.000Z",
  "maintainerBlessed": false,
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "jsdom",
      "kind": "edit",
      "files": [
        {
          "path": "types/jsdom/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/jsdom/ts3.3/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/jsdom/ts3.3/jsdom-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/jsdom/ts3.3/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/jsdom/ts3.3/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/jsdom/ts3.4/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "leonard-thieu",
        "palmfjord",
        "ExE-Boss"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "ciResult": "pass"
}

[typescript-bot]

🔔 @leonard-thieu @palmfjord @ExE-Boss — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#50559	diff
Batch compilation
Memory usage (MiB)	112.0	114.5	+2.2%
Type count	18642	18642	0%
Assignability cache size	5951	5951	0%
Language service
Samples taken	31	31	0%
Identifiers in tests	31	31	0%
getCompletionsAtPosition
Mean duration (ms)	717.3	714.5	-0.4%
Mean CV	9.8%	9.1%
Worst duration (ms)	899.6	841.6	-6.4%
Worst identifier	domWindow	Atomics
getQuickInfoAtPosition
Mean duration (ms)	706.3	691.0	-2.2%
Mean CV	10.3%	7.5%
Worst duration (ms)	879.9	841.6	-4.4%
Worst identifier	WebAssembly	WebAssembly

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[typescript-bot]

I just published @types/jsdom@16.2.6 to npm.