Skip to content

wavesurfer.js: fix incorrect type for a property#51567

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
indutny:fix/wavesurfer.js
Mar 5, 2021
Merged

wavesurfer.js: fix incorrect type for a property#51567
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
indutny:fix/wavesurfer.js

Conversation

@indutny
Copy link
Copy Markdown
Contributor

@indutny indutny commented Mar 5, 2021

isReady is a boolean value and not a function.

See: https://wavesurfer-js.org/api/class/src/wavesurfer.js~WaveSurfer.html#instance-member-isReady

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Mar 5, 2021

@indutny Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 51567,
  "author": "indutny",
  "headCommitOid": "8b1e79db47d0224a1f4cb7ad83aabd856e6036a7",
  "lastPushDate": "2021-03-05T00:43:23.000Z",
  "lastActivityDate": "2021-03-05T10:05:49.000Z",
  "maintainerBlessed": false,
  "mergeOfferDate": "2021-03-05T01:26:48.000Z",
  "mergeRequestDate": "2021-03-05T10:05:49.000Z",
  "mergeRequestUser": "kubk",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "wavesurfer.js",
      "kind": "edit",
      "files": [
        {
          "path": "types/wavesurfer.js/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/wavesurfer.js/wavesurfer.js-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "higuri",
        "kubk",
        "bennordgengo"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "higuri",
      "date": "2021-03-05T01:26:09.000Z",
      "isMaintainer": false
    }
  ],
  "ciResult": "pass"
}

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @higuri @kubk @bennordgengo — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot
Copy link
Copy Markdown
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #51567 diff
Batch compilation
Memory usage (MiB) 83.2 72.1 -13.2%
Type count 10609 10610 0%
Assignability cache size 3655 3655 0%
Language service
Samples taken 51 54 +6%
Identifiers in tests 51 54 +6%
getCompletionsAtPosition
    Mean duration (ms) 414.0 409.0 -1.2%
    Mean CV 11.8% 11.8%
    Worst duration (ms) 521.8 520.4 -0.3%
    Worst identifier container WaveSurfer
getQuickInfoAtPosition
    Mean duration (ms) 415.4 410.8 -1.1%
    Mean CV 11.6% 11.9%
    Worst duration (ms) 515.9 489.8 -5.1%
    Worst identifier foo waveColor

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Mar 5, 2021
Copy link
Copy Markdown
Contributor

@higuri higuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Mar 5, 2021
@typescript-bot
Copy link
Copy Markdown
Contributor

@indutny Everything looks good here. Great job! I am ready to merge this PR (at 8b1e79d) on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@higuri, @kubk, @bennordgengo: you can do this too.)

@kubk
Copy link
Copy Markdown
Contributor

kubk commented Mar 5, 2021

Ready to merge

@typescript-bot typescript-bot merged commit c390092 into DefinitelyTyped:master Mar 5, 2021
@typescript-bot
Copy link
Copy Markdown
Contributor

I just published @types/wavesurfer.js@3.3.2 to npm.

@indutny indutny deleted the fix/wavesurfer.js branch March 5, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants