[faker] added faker.internet.port method

[scarabedore]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:
If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/Marak/faker.js/pull/1009
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

[typescript-bot]

@scarabedore Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• faker on npm, on unpkg
  • owner-approval: @pkuczynski
  • 1 removed owner: @pkuczynski

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 52252,
  "author": "scarabedore",
  "headCommitOid": "3e891b06c77293519767ae57b45e01b4e721a938",
  "lastPushDate": "2021-04-08T05:37:45.000Z",
  "lastActivityDate": "2021-04-19T09:32:28.000Z",
  "maintainerBlessed": false,
  "mergeOfferDate": "2021-04-19T09:22:42.000Z",
  "mergeRequestDate": "2021-04-19T09:32:28.000Z",
  "mergeRequestUser": "pkuczynski",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "faker",
      "kind": "edit",
      "files": [
        {
          "path": "types/faker/faker-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/faker/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "bensw",
        "basp",
        "Kuniwak",
        "mattbishop",
        "testica",
        "TastefulElk",
        "damonpam",
        "heavenshell",
        "pkuczynski"
      ],
      "addedOwners": [],
      "deletedOwners": [
        "pkuczynski"
      ],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "pkuczynski",
      "date": "2021-04-19T09:22:05.000Z",
      "isMaintainer": false
    }
  ],
  "ciResult": "pass"
}

[typescript-bot]

🔔 @bensw @basp @Kuniwak @mattbishop @testica @TastefulElk @damonpam @heavenshell @pkuczynski — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#52252	diff
Batch compilation
Memory usage (MiB)	41.9	41.9	+0.1%
Type count	2630	2631	0%
Assignability cache size	145	145	0%
Language service
Samples taken	1450	1454	0%
Identifiers in tests	1450	1454	0%
getCompletionsAtPosition
Mean duration (ms)	123.2	134.0	+8.8%
Mean CV	9.5%	9.9%
Worst duration (ms)	174.2	176.0	+1.0%
Worst identifier	firstName	firstName
getQuickInfoAtPosition
Mean duration (ms)	125.0	135.9	+8.6%
Mean CV	7.9%	7.5%
Worst duration (ms)	171.8	193.8	+12.8%
Worst identifier	unique	unique
System information
Node version	v14.16.0	v14.16.0
CPU count	2	2
CPU speed	2.294 GHz	2.394 GHz
CPU model	Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz	Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
CPU Architecture	x64	x64
Memory	6.8 GiB	6.8 GiB
Platform	linux	linux
Release	4.15.0-1111-azure	4.15.0-1111-azure

First off, note that the system varied slightly between these two runs, so you’ll have to take these measurements with a grain of salt.

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[typescript-bot]

Re-ping @bensw, @basp, @Kuniwak, @mattbishop, @testica, @TastefulElk, @damonpam, @heavenshell, @pkuczynski:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[typescript-bot]

@scarabedore Everything looks good here. Great job! I am ready to merge this PR (at 3e891b0) on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@bensw, @basp, @Kuniwak, @mattbishop, @testica, @TastefulElk, @damonpam, @heavenshell, @pkuczynski: you can do this too.)

[pkuczynski]

Ready to merge

[typescript-bot]

I just published @types/faker@5.5.3 to npm.