Skip to content

update(typopo): v2.5#53707

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
peterblazejewicz:update/typopo
Jul 1, 2021
Merged

update(typopo): v2.5#53707
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
peterblazejewicz:update/typopo

Conversation

@peterblazejewicz
Copy link
Copy Markdown
Member

  • new configuration option
  • version bump

https://github.com/surfinzap/typopo/releases/tag/2/5/0

Thanks!

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change.
  • Run npm test <package to test>.
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

- new configuration option
- version bump

https://github.com/surfinzap/typopo/releases/tag/2/5/0

Thanks!
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jun 9, 2021

@peterblazejewicz Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 53707,
  "author": "peterblazejewicz",
  "headCommitOid": "4785f506d5ccc6274875f388fd12caaf959070ac",
  "lastPushDate": "2021-06-09T18:33:14.000Z",
  "lastActivityDate": "2021-07-01T20:40:21.000Z",
  "mergeOfferDate": "2021-07-01T08:21:47.000Z",
  "mergeRequestDate": "2021-07-01T20:40:21.000Z",
  "mergeRequestUser": "peterblazejewicz",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "typopo",
      "kind": "edit",
      "files": [
        {
          "path": "types/typopo/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/typopo/typopo-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "DanielRosenwasser",
      "date": "2021-07-01T08:21:11.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 857959740,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Author is Owner The author of this PR is a listed owner of the package. No Other Owners This DT module only has one owner, so we can't have someone verify the change. labels Jun 9, 2021
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @peterblazejewicz — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot
Copy link
Copy Markdown
Contributor

Re-ping @«anyone?»:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Jun 20, 2021
@typescript-bot
Copy link
Copy Markdown
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @peterblazejewicz.

(Ping @«anyone?».)

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Jul 1, 2021
@typescript-bot
Copy link
Copy Markdown
Contributor

@peterblazejewicz Everything looks good here. Great job! I am ready to merge this PR (at 4785f50) on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@peterblazejewicz
Copy link
Copy Markdown
Member Author

Ready to merge 💘

@typescript-bot typescript-bot merged commit 0a0839f into DefinitelyTyped:master Jul 1, 2021
@peterblazejewicz peterblazejewicz deleted the update/typopo branch July 1, 2021 20:41
@typescript-bot
Copy link
Copy Markdown
Contributor

I just published @types/typopo@2.5.0 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. Maintainer Approved No Other Owners This DT module only has one owner, so we can't have someone verify the change. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants