Skip to content

Fix koi-joi-router multipartOptions type#55392

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
zsjie:master
Sep 14, 2021
Merged

Fix koi-joi-router multipartOptions type#55392
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
zsjie:master

Conversation

@zsjie
Copy link
Copy Markdown
Contributor

@zsjie zsjie commented Aug 26, 2021

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/koajs/joi-router
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Aug 26, 2021

@zsjie Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 55392,
  "author": "zsjie",
  "headCommitOid": "a76bd1ae0e276fae698b0be88d02ccd8201f2aaf",
  "lastPushDate": "2021-08-26T09:05:13.000Z",
  "lastActivityDate": "2021-09-14T01:41:10.000Z",
  "mergeOfferDate": "2021-09-13T16:11:18.000Z",
  "mergeRequestDate": "2021-09-14T01:41:10.000Z",
  "mergeRequestUser": "zsjie",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "koa-joi-router",
      "kind": "edit",
      "files": [
        {
          "path": "types/koa-joi-router/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/koa-joi-router/koa-joi-router-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "wingsbob",
        "move-zig",
        "hirochachacha",
        "NotWoods",
        "sourrust"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "wingsbob",
      "date": "2021-09-13T16:10:41.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 906238332,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @wingsbob @move-zig @hirochachacha @NotWoods @sourrust — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot
Copy link
Copy Markdown
Contributor

Re-ping @wingsbob, @move-zig, @hirochachacha, @NotWoods, @sourrust:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Sep 6, 2021
@typescript-bot
Copy link
Copy Markdown
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @zsjie.

(Ping @wingsbob, @move-zig, @hirochachacha, @NotWoods, @sourrust.)

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Sep 13, 2021
@typescript-bot
Copy link
Copy Markdown
Contributor

@zsjie: Everything looks good here. I am ready to merge this PR (at a76bd1a) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@wingsbob, @move-zig, @hirochachacha, @NotWoods, @sourrust: you can do this too.)

@zsjie
Copy link
Copy Markdown
Contributor Author

zsjie commented Sep 14, 2021

Ready to merge

@typescript-bot typescript-bot merged commit c4ef586 into DefinitelyTyped:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants