Skip to content

[gapi.client.*] Bulk update Google API namespace#55712

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
Maxim-Mazurok:gapi-update
Sep 14, 2021
Merged

[gapi.client.*] Bulk update Google API namespace#55712
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
Maxim-Mazurok:gapi-update

Conversation

@Maxim-Mazurok
Copy link
Copy Markdown
Contributor

@Maxim-Mazurok Maxim-Mazurok commented Sep 12, 2021

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should contain { "extends": "dtslint/dt.json" }, and no additional rules.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

Related to Maxim-Mazurok/google-api-typings-generator#554
As seen previously in #53354 #52618
Blocked by microsoft/DefinitelyTyped-tools#311

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Sep 14, 2021

@Maxim-Mazurok Thank you for submitting this PR!

This is a live comment which I will keep updated.

25 packages in this PR

Code Reviews

This PR can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes when there are new packages added

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 55712,
  "author": "Maxim-Mazurok",
  "headCommitOid": "37685ae1335c7d838902cdf0c2836fe45826480e",
  "lastPushDate": "2021-09-14T00:41:42.000Z",
  "lastActivityDate": "2021-09-14T10:30:47.000Z",
  "maintainerBlessed": "Waiting for Author to Merge",
  "mergeOfferDate": "2021-09-14T10:04:08.000Z",
  "mergeRequestDate": "2021-09-14T10:30:47.000Z",
  "mergeRequestUser": "Maxim-Mazurok",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "gapi.client.accessapproval",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.accessapproval/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.admin",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.admin/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.compute",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.compute/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.contactcenterinsights",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.contactcenterinsights/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.contactcenterinsights/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.contactcenterinsights/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.contactcenterinsights/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.datacatalog",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.datacatalog/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.fcmdata",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.fcmdata/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.fcmdata/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.fcmdata/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.fcmdata/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.firebaseappcheck",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.firebaseappcheck/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.firebaseappcheck/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.firebaseappcheck/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.firebaseappcheck/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.genomics",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.genomics/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.gkehub",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.gkehub/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.ideahub",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.ideahub/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.ideahub/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.ideahub/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.ideahub/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.keep",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.keep/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.keep/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.keep/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.keep/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.mybusinessbusinessinformation",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.mybusinessbusinessinformation/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.mybusinessbusinessinformation/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.mybusinessbusinessinformation/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.mybusinessbusinessinformation/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.mybusinessnotifications",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.mybusinessnotifications/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.mybusinessnotifications/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.mybusinessnotifications/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.mybusinessnotifications/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.mybusinessverifications",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.mybusinessverifications/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.mybusinessverifications/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.mybusinessverifications/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.mybusinessverifications/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.networkconnectivity",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.networkconnectivity/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.networksecurity",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.networksecurity/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.networksecurity/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.networksecurity/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.networksecurity/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.networkservices",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.networkservices/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.networkservices/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.networkservices/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.networkservices/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.notebooks",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.notebooks/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.policyanalyzer",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.policyanalyzer/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.policyanalyzer/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.policyanalyzer/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.policyanalyzer/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.privateca",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.privateca/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.remotebuildexecution",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.remotebuildexecution/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.resourcesettings",
      "kind": "add",
      "files": [
        {
          "path": "types/gapi.client.resourcesettings/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gapi.client.resourcesettings/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.resourcesettings/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/gapi.client.resourcesettings/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        }
      ],
      "owners": [],
      "addedOwners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.sqladmin",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.sqladmin/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.tasks",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.tasks/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gapi.client.vault",
      "kind": "edit",
      "files": [
        {
          "path": "types/gapi.client.vault/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Maxim-Mazurok",
        "namoscato",
        "declanvong"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 918693416,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added The CI failed When GH Actions fails New Definition This PR creates a new definition package. Edits multiple packages Untested Change This PR does not touch tests Check Config Changes a module config files labels Sep 14, 2021
@typescript-bot
Copy link
Copy Markdown
Contributor

Hey @Maxim-Mazurok,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @namoscato @declanvong — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot
Copy link
Copy Markdown
Contributor

@Maxim-Mazurok The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot added Self Merge This PR can now be self-merged by the PR author or an owner and removed The CI failed When GH Actions fails labels Sep 14, 2021
@typescript-bot
Copy link
Copy Markdown
Contributor

@Maxim-Mazurok: Everything looks good here. I am ready to merge this PR (at 37685ae) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@Maxim-Mazurok
Copy link
Copy Markdown
Contributor Author

Ready to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Check Config Changes a module config files Edits multiple packages New Definition This PR creates a new definition package. Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants