Skip to content

@ckeditor/ckeditor5-link remove old v27 and v28#56663

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
fedemp:ckeditor5-link-remove-v27-v28
Oct 21, 2021
Merged

@ckeditor/ckeditor5-link remove old v27 and v28#56663
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
fedemp:ckeditor5-link-remove-v27-v28

Conversation

@fedemp
Copy link
Copy Markdown
Contributor

@fedemp fedemp commented Oct 20, 2021

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Oct 20, 2021

@fedemp Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 56663,
  "author": "fedemp",
  "headCommitOid": "1a50a5f30d4e9dfcbad88a621cc5d4566ee27a64",
  "lastPushDate": "2021-10-20T23:57:04.000Z",
  "lastActivityDate": "2021-10-21T16:31:00.000Z",
  "mergeOfferDate": "2021-10-21T14:29:58.000Z",
  "mergeRequestDate": "2021-10-21T16:31:00.000Z",
  "mergeRequestUser": "fedemp",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "ckeditor__ckeditor5-link",
      "kind": "edit",
      "files": [
        {
          "path": "types/ckeditor__ckeditor5-link/v27/OTHER_FILES.txt",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v27/ckeditor__ckeditor5-link-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v27/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v27/src/autolink.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v27/src/link.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v27/src/linkcommand.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v27/src/linkediting.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v27/src/linkimage.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v27/src/linkimageediting.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v27/src/linkimageui.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v27/src/linkui.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v27/src/ui/linkactionsview.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v27/src/ui/linkformview.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v27/src/unlinkcommand.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v27/src/utils.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v27/src/utils/automaticdecorators.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v27/src/utils/manualdecorator.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v27/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v27/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v28/ckeditor__ckeditor5-link-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v28/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v28/src/autolink.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v28/src/link.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v28/src/linkcommand.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v28/src/linkediting.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v28/src/linkimage.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v28/src/linkimageediting.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v28/src/linkimageui.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v28/src/linkui.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v28/src/ui/linkactionsview.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v28/src/ui/linkformview.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v28/src/unlinkcommand.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v28/src/utils.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v28/src/utils/automaticdecorators.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v28/src/utils/manualdecorator.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v28/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/ckeditor__ckeditor5-link/v28/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "fedemp"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "fdintino",
      "date": "2021-10-21T14:29:19.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 948121228,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Author is Owner The author of this PR is a listed owner of the package. No Other Owners This DT module only has one owner, so we can't have someone verify the change. labels Oct 20, 2021
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @fedemp — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner labels Oct 21, 2021
@typescript-bot
Copy link
Copy Markdown
Contributor

@fedemp: Everything looks good here. I am ready to merge this PR (at 1a50a5f) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@fedemp
Copy link
Copy Markdown
Contributor Author

fedemp commented Oct 21, 2021

Ready to merge

@typescript-bot typescript-bot merged commit e0d66e5 into DefinitelyTyped:master Oct 21, 2021
@fedemp fedemp deleted the ckeditor5-link-remove-v27-v28 branch October 21, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. No Other Owners This DT module only has one owner, so we can't have someone verify the change. Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants