Hack around remark-validate-link warnings#58599
Merged
amcasey merged 1 commit intoDefinitelyTyped:masterfrom Feb 4, 2022
Merged
Hack around remark-validate-link warnings#58599amcasey merged 1 commit intoDefinitelyTyped:masterfrom
amcasey merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
It appears that `remark-validate-link` uses `hosted-git-info` to convert our GH permalink into a relative link (since it shares a prefix with our GH repo) and then warns that the relative link is dangling. This change uses URL encoding to defeat the tool's simple prefix matching. Filed DefinitelyTyped#58598 to investigate a real solution.
Contributor
|
@amcasey Thank you for submitting this PR! This is a live comment which I will keep updated. This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this? 0 packages in this PR (and infra files)
Code ReviewsThere aren't any other owners of this package, so a DT maintainer will review it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 58599,
"author": "amcasey",
"headCommitOid": "b3c6a16668d620adecf4f9e5e8fd29ccc2060a18",
"mergeBaseOid": "0c4fe9aa89dac0e458677e0f697bca253bccabed",
"lastPushDate": "2022-02-04T01:47:24.000Z",
"lastActivityDate": "2022-02-04T01:47:56.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "README.es.md",
"kind": "infrastructure"
},
{
"path": "README.it.md",
"kind": "infrastructure"
},
{
"path": "README.ja.md",
"kind": "infrastructure"
},
{
"path": "README.ko.md",
"kind": "infrastructure"
},
{
"path": "README.md",
"kind": "infrastructure"
},
{
"path": "README.pt.md",
"kind": "infrastructure"
},
{
"path": "README.ru.md",
"kind": "infrastructure"
},
{
"path": "README.zh.md",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [],
"mainBotCommentID": 1029565410,
"ciResult": "pass"
} |
Contributor
|
🔔 @amcasey — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
martin-badin
pushed a commit
to martin-badin/DefinitelyTyped
that referenced
this pull request
Feb 23, 2022
It appears that `remark-validate-link` uses `hosted-git-info` to convert our GH permalink into a relative link (since it shares a prefix with our GH repo) and then warns that the relative link is dangling. This change uses URL encoding to defeat the tool's simple prefix matching. Filed DefinitelyTyped#58598 to investigate a real solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that
remark-validate-linkuseshosted-git-infoto convert our GH permalink into a relative link (since it shares a prefix with our GH repo) and then warns that the relative link is dangling. This change uses URL encoding to defeat the tool's simple prefix matching.Filed #58598 to investigate a real solution.