fix(mermaid): add missing configuration types#58851
fix(mermaid): add missing configuration types#58851typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
Conversation
|
@quank123wip Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 58851,
"author": "quank123wip",
"headCommitOid": "a8c0bf9494e33140fdf31ed27dc0e2ea342c917a",
"mergeBaseOid": "a96f8c2be7ae8a465a2a06c6a2d34b23e6ea1b4d",
"lastPushDate": "2022-02-18T06:25:12.000Z",
"lastActivityDate": "2022-03-02T05:09:25.000Z",
"mergeOfferDate": "2022-03-02T02:05:17.000Z",
"mergeRequestDate": "2022-03-02T05:09:25.000Z",
"mergeRequestUser": "quank123wip",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "mermaid",
"kind": "edit",
"files": [
{
"path": "types/mermaid/mermaid-tests.ts",
"kind": "test"
},
{
"path": "types/mermaid/mermaidAPI.d.ts",
"kind": "definition"
}
],
"owners": [
"ggilmore"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "ggilmore",
"date": "2022-03-02T02:04:35.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1043983472,
"ciResult": "pass"
} |
|
🔔 @ggilmore — please review this PR in the next few days. Be sure to explicitly select |
|
Re-ping @ggilmore: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
|
|
||
| class?: any; | ||
| git?: any; | ||
| journey?: any; // [todo] |
There was a problem hiding this comment.
Are these // TODO comments necessary?
There was a problem hiding this comment.
Keeping these types as any isn't right, but it's a temporary solution. I currently have no time, and would submit a PR in future for this. Keep these todo comment is nothing wrong IMO.
|
@quank123wip: Everything looks good here. I am ready to merge this PR (at a8c0bf9) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@ggilmore: you can do this too.) |
|
Ready to merge |
Please fill in this template.
Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change.
Follow the advice from the readme.
Avoid common mistakes.
Run
npm test <package to test>.Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/mermaid-js/mermaid/blob/8.9.2/src/defaultConfig.js