Skip to content

fix(mermaid): add missing configuration types#58851

Merged
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
quank123wip:master
Mar 2, 2022
Merged

fix(mermaid): add missing configuration types#58851
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
quank123wip:master

Conversation

@quank123wip
Copy link
Copy Markdown

@quank123wip quank123wip commented Feb 18, 2022

Please fill in this template.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Feb 18, 2022

@quank123wip Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 58851,
  "author": "quank123wip",
  "headCommitOid": "a8c0bf9494e33140fdf31ed27dc0e2ea342c917a",
  "mergeBaseOid": "a96f8c2be7ae8a465a2a06c6a2d34b23e6ea1b4d",
  "lastPushDate": "2022-02-18T06:25:12.000Z",
  "lastActivityDate": "2022-03-02T05:09:25.000Z",
  "mergeOfferDate": "2022-03-02T02:05:17.000Z",
  "mergeRequestDate": "2022-03-02T05:09:25.000Z",
  "mergeRequestUser": "quank123wip",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "mermaid",
      "kind": "edit",
      "files": [
        {
          "path": "types/mermaid/mermaid-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/mermaid/mermaidAPI.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "ggilmore"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "ggilmore",
      "date": "2022-03-02T02:04:35.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1043983472,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Untested Change This PR does not touch tests label Feb 18, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @ggilmore — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot removed the Untested Change This PR does not touch tests label Feb 18, 2022
@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Mar 1, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

Re-ping @ggilmore:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!


class?: any;
git?: any;
journey?: any; // [todo]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these // TODO comments necessary?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping these types as any isn't right, but it's a temporary solution. I currently have no time, and would submit a PR in future for this. Keep these todo comment is nothing wrong IMO.

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Mar 2, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

@quank123wip: Everything looks good here. I am ready to merge this PR (at a8c0bf9) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@ggilmore: you can do this too.)

@quank123wip
Copy link
Copy Markdown
Author

Ready to merge

@typescript-bot typescript-bot merged commit 8c078db into DefinitelyTyped:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants