Skip to content

Update chess.js to v0.13: Move constants to top level#60098

Merged
typescript-bot merged 3 commits intoDefinitelyTyped:masterfrom
CapOfCave:master
May 16, 2022
Merged

Update chess.js to v0.13: Move constants to top level#60098
typescript-bot merged 3 commits intoDefinitelyTyped:masterfrom
CapOfCave:master

Conversation

@CapOfCave
Copy link
Copy Markdown
Contributor

chess.js received a major update in v0.13.0. All constants were moved to the top level of the module (as seen in this commit). This results in a breaking change in both the library itself and its types. Updating this types package without increasing the major version should, however, not cause any trouble since

  1. it's still considered unstable according to semver as indicated by major version zero
  2. it only follows the breaking change in chess.js itself, instead of introducing a new breaking point

This pull request aims to upgrade to the newest chess.js version with minimal changes. Further refactoring could be done to better align this package with the guidelines. This is, however, out of scope for this PR.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: url here
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 27, 2022

@CapOfCave Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 60098,
  "author": "CapOfCave",
  "headCommitOid": "1dc1f9295f9e0734673bdae1950f05335d82b250",
  "mergeBaseOid": "82c30c3593f84f6d6a7f3bd1ca00cf317c92e094",
  "lastPushDate": "2022-04-27T20:40:38.000Z",
  "lastActivityDate": "2022-05-16T21:41:52.000Z",
  "mergeOfferDate": "2022-05-16T20:44:42.000Z",
  "mergeRequestDate": "2022-05-16T21:41:52.000Z",
  "mergeRequestUser": "CapOfCave",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "chess.js",
      "kind": "edit",
      "files": [
        {
          "path": "types/chess.js/chess.js-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/chess.js/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "JacobFischer",
        "zacnomore"
      ],
      "addedOwners": [
        "CapOfCave"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "gabritto",
      "date": "2022-05-16T20:44:01.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1111452688,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Edits Owners This PR adds or removes owners label Apr 27, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @JacobFischer @zacnomore — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot
Copy link
Copy Markdown
Contributor

Re-ping @JacobFischer, @zacnomore:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label May 9, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @CapOfCave.

(Ping @JacobFischer, @zacnomore.)

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels May 16, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

@CapOfCave: Everything looks good here. I am ready to merge this PR (at 1dc1f92) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@JacobFischer, @zacnomore: you can do this too.)

@CapOfCave
Copy link
Copy Markdown
Contributor Author

Ready to merge

@typescript-bot typescript-bot merged commit 063f0c8 into DefinitelyTyped:master May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Edits Owners This PR adds or removes owners Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants