Skip to content

[mssql] add ConnectionPool.parseConnectionString() static method definition#60197

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
dhensby:pulls/mssql
May 17, 2022
Merged

[mssql] add ConnectionPool.parseConnectionString() static method definition#60197
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
dhensby:pulls/mssql

Conversation

@dhensby
Copy link
Copy Markdown
Contributor

@dhensby dhensby commented May 5, 2022

Add the ConnectionPool.parseConnectionString() method that was added in v8 of the mssql lib

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented May 5, 2022

@dhensby Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 60197,
  "author": "dhensby",
  "headCommitOid": "8a32dd07cf127fdb6d461d108b6bfc55c50160f6",
  "mergeBaseOid": "ec3525c11ef9f60e731b9a0e9bd64bfc4bf9fdab",
  "lastPushDate": "2022-05-05T11:29:24.000Z",
  "lastActivityDate": "2022-05-17T08:04:14.000Z",
  "mergeOfferDate": "2022-05-17T04:55:59.000Z",
  "mergeRequestDate": "2022-05-17T08:04:14.000Z",
  "mergeRequestUser": "dhensby",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "mssql",
      "kind": "edit",
      "files": [
        {
          "path": "types/mssql/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/mssql/mssql-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "elhaard",
        "pkeuter",
        "woodenconsulting",
        "cahilfoley",
        "achrinza",
        "dhensby"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "achrinza",
      "date": "2022-05-17T04:55:18.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1118444747,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Author is Owner The author of this PR is a listed owner of the package. labels May 5, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @elhaard @pkeuter @woodenconsulting @cahilfoley @achrinza — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@DangerBotOSS
Copy link
Copy Markdown

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

mssql (unpkg)

was missing the following properties:

  1. getTypeByValue
  2. close
  3. on
  4. removeListener
  5. off
as well as these 1 other properties...

batch

Generated by 🚫 dangerJS against 8a32dd0

@typescript-bot
Copy link
Copy Markdown
Contributor

Re-ping @elhaard, @pkeuter, @woodenconsulting, @cahilfoley, @achrinza:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label May 16, 2022
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels May 17, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

@dhensby: Everything looks good here. I am ready to merge this PR (at 8a32dd0) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@elhaard, @pkeuter, @woodenconsulting, @cahilfoley, @achrinza: you can do this too.)

@dhensby
Copy link
Copy Markdown
Contributor Author

dhensby commented May 17, 2022

Ready to merge

@typescript-bot typescript-bot merged commit 48863b4 into DefinitelyTyped:master May 17, 2022
@dhensby dhensby deleted the pulls/mssql branch June 15, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants