Skip to content

feat(aws-lambda): add cloudfront event record type#60240

Merged
typescript-bot merged 6 commits intoDefinitelyTyped:masterfrom
naorpeled:feat/aws-lambda/update-cloudfront-types
May 8, 2022
Merged

feat(aws-lambda): add cloudfront event record type#60240
typescript-bot merged 6 commits intoDefinitelyTyped:masterfrom
naorpeled:feat/aws-lambda/update-cloudfront-types

Conversation

@naorpeled
Copy link
Copy Markdown
Contributor

@naorpeled naorpeled commented May 6, 2022

Please fill in this template.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented May 6, 2022

@naorpeled Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 60240,
  "author": "naorpeled",
  "headCommitOid": "547505437292a21323a79773aa0390e98cd81d5e",
  "mergeBaseOid": "ec6e5981ab3c59704942f53f976cc0150f2feb39",
  "lastPushDate": "2022-05-07T00:03:57.000Z",
  "lastActivityDate": "2022-05-08T20:45:43.000Z",
  "mergeOfferDate": "2022-05-08T20:44:08.000Z",
  "mergeRequestDate": "2022-05-08T20:45:43.000Z",
  "mergeRequestUser": "naorpeled",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "aws-lambda",
      "kind": "edit",
      "files": [
        {
          "path": "types/aws-lambda/test/cloudfront-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/aws-lambda/trigger/cloudfront-request.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "darbio",
        "skarum",
        "StefH",
        "buggy",
        "y13i",
        "wwwy3y3",
        "OrthoDex",
        "MichaelMarner",
        "daniel-cottone",
        "kostya-misura",
        "coderbyheart",
        "palmithor",
        "daniloraisi",
        "simonbuchan",
        "Haydabase",
        "repl-chris",
        "aneilbaboo",
        "jeznag",
        "louislarry",
        "dpapukchiev",
        "ohookins",
        "trevor-leach",
        "jagregory",
        "dalen",
        "loikg",
        "skyzenr",
        "redlickigrzegorz",
        "juancarbonel",
        "pwmcintyre",
        "alex-bolenok-centralreach",
        "marianzange",
        "apepper",
        "apalumbo",
        "SachinShekhar",
        "ivanmartos",
        "zach-anthony",
        "savnik",
        "svenmilewski",
        "bboure",
        "jamesorlakin",
        "aphex",
        "joeykilpatrick"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2022-05-08T20:43:29.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "joeykilpatrick",
      "date": "2022-05-07T15:49:37.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1120078587,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label May 7, 2022
Copy link
Copy Markdown
Member

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels May 8, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

@naorpeled: Everything looks good here. I am ready to merge this PR (at 5475054) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@darbio, @skarum, @StefH, @buggy, @y13i, @wwwy3y3, @OrthoDex, @MichaelMarner, @daniel-cottone, @kostya-misura, @coderbyheart, @palmithor, @daniloraisi, @simonbuchan, @Haydabase, @repl-chris, @aneilbaboo, @jeznag, @louislarry, @dpapukchiev, @ohookins, @trevor-leach, @jagregory, @dalen, @loikg, @skyzenr, @redlickigrzegorz, @juancarbonel, @pwmcintyre, @alex-bolenok-centralreach, @marianzange, @apepper, @apalumbo, @SachinShekhar, @ivanmartos, @zach-anthony, @savnik, @svenmilewski, @bboure, @jamesorlakin, @aphex, @joeykilpatrick: you can do this too.)

@naorpeled
Copy link
Copy Markdown
Contributor Author

Ready to merge

@typescript-bot typescript-bot merged commit 239652a into DefinitelyTyped:master May 8, 2022
@naorpeled naorpeled deleted the feat/aws-lambda/update-cloudfront-types branch May 9, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Critical package Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants