Skip to content

[asn1js] rm typings as they are now provided by upstream library#60315

Merged
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
dhensby:pulls/rm-asn1js
May 16, 2022
Merged

[asn1js] rm typings as they are now provided by upstream library#60315
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
dhensby:pulls/rm-asn1js

Conversation

@dhensby
Copy link
Copy Markdown
Contributor

@dhensby dhensby commented May 12, 2022

Please fill in this template.

Select one of these and delete the others:

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented May 12, 2022

@dhensby Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

2 packages in this PR (and infra files)

Code Reviews

Because this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer needs to approve changes which affect DT infrastructure (notNeededPackages.json)

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 60315,
  "author": "dhensby",
  "headCommitOid": "ace19bf13882440617d7feab9ef505340b02d0af",
  "mergeBaseOid": "063c09f5361fb081e09221d955c565f4c60fd0f1",
  "lastPushDate": "2022-05-13T23:05:22.000Z",
  "lastActivityDate": "2022-05-16T17:27:00.000Z",
  "mergeOfferDate": "2022-05-16T15:33:03.000Z",
  "mergeRequestDate": "2022-05-16T17:27:00.000Z",
  "mergeRequestUser": "dhensby",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "notNeededPackages.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "asn1js",
      "kind": "delete",
      "files": [
        {
          "path": "types/asn1js/asn1js-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/asn1js/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/asn1js/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/asn1js/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "microshine"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "pkijs",
      "kind": "edit",
      "files": [
        {
          "path": "types/pkijs/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "microshine"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "gabritto",
      "date": "2022-05-16T15:32:21.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1125528166,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Edits Infrastructure labels May 12, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @microshine — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label May 13, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

@dhensby The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot added Edits multiple packages The CI failed When GH Actions fails and removed The CI failed When GH Actions fails labels May 13, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

@dhensby The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@dhensby dhensby force-pushed the pulls/rm-asn1js branch from b8c2fc4 to ace19bf Compare May 13, 2022 23:05
@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label May 13, 2022
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels May 16, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

@dhensby: Everything looks good here. I am ready to merge this PR (at ace19bf) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@dhensby
Copy link
Copy Markdown
Contributor Author

dhensby commented May 16, 2022

Ready to merge

@typescript-bot typescript-bot merged commit c3b0a14 into DefinitelyTyped:master May 16, 2022
@dhensby dhensby deleted the pulls/rm-asn1js branch May 16, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Edits Infrastructure Edits multiple packages Maintainer Approved Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants