[asn1js] rm typings as they are now provided by upstream library#60315
[asn1js] rm typings as they are now provided by upstream library#60315typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
Conversation
|
@dhensby Thank you for submitting this PR! This is a live comment which I will keep updated. This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this? 2 packages in this PR (and infra files)Code ReviewsBecause this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 60315,
"author": "dhensby",
"headCommitOid": "ace19bf13882440617d7feab9ef505340b02d0af",
"mergeBaseOid": "063c09f5361fb081e09221d955c565f4c60fd0f1",
"lastPushDate": "2022-05-13T23:05:22.000Z",
"lastActivityDate": "2022-05-16T17:27:00.000Z",
"mergeOfferDate": "2022-05-16T15:33:03.000Z",
"mergeRequestDate": "2022-05-16T17:27:00.000Z",
"mergeRequestUser": "dhensby",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "notNeededPackages.json",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "asn1js",
"kind": "delete",
"files": [
{
"path": "types/asn1js/asn1js-tests.ts",
"kind": "test"
},
{
"path": "types/asn1js/index.d.ts",
"kind": "definition"
},
{
"path": "types/asn1js/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/asn1js/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"microshine"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
},
{
"name": "pkijs",
"kind": "edit",
"files": [
{
"path": "types/pkijs/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"microshine"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "gabritto",
"date": "2022-05-16T15:32:21.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1125528166,
"ciResult": "pass"
} |
|
🔔 @microshine — please review this PR in the next few days. Be sure to explicitly select |
|
@dhensby The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
@dhensby The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
@dhensby: Everything looks good here. I am ready to merge this PR (at ace19bf) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
|
Ready to merge |
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If removing a declaration:
notNeededPackages.json.