Skip to content

feat: update @nginstack/dev-tools definitions#60372

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
paulocmoreno:@nginstack/dev-tools
May 16, 2022
Merged

feat: update @nginstack/dev-tools definitions#60372
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
paulocmoreno:@nginstack/dev-tools

Conversation

@paulocmoreno
Copy link
Copy Markdown
Contributor

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should contain { "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented May 16, 2022

@paulocmoreno Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 60372,
  "author": "paulocmoreno",
  "headCommitOid": "1476643f96d3f650ae2b2f1d66c8f5aaba706ca1",
  "mergeBaseOid": "c3b0a14c93a0c918b65bd0dc5bbda5d97d7bb7e7",
  "lastPushDate": "2022-05-16T19:49:21.000Z",
  "lastActivityDate": "2022-05-16T19:59:31.000Z",
  "mergeOfferDate": "2022-05-16T19:58:48.000Z",
  "mergeRequestDate": "2022-05-16T19:59:31.000Z",
  "mergeRequestUser": "Henato",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "nginstack__dev-tools",
      "kind": "edit",
      "files": [
        {
          "path": "types/nginstack__dev-tools/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/nginstack__dev-tools/nginstack__dev-tools-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Henato",
        "paulocmoreno"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "Henato",
      "date": "2022-05-16T19:57:22.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1128074322,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Author is Owner The author of this PR is a listed owner of the package. label May 16, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @Henato — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels May 16, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

@paulocmoreno: Everything looks good here. I am ready to merge this PR (at 1476643) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@Henato: you can do this too.)

@Henato
Copy link
Copy Markdown
Contributor

Henato commented May 16, 2022

Ready to merge

@typescript-bot typescript-bot merged commit 0e5a1f3 into DefinitelyTyped:master May 16, 2022
@paulocmoreno paulocmoreno deleted the @nginstack/dev-tools branch May 16, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants