Skip to content

Fix fs-extra usage in scripts#63732

Merged
sandersn merged 1 commit intoDefinitelyTyped:masterfrom
remcohaszing:fix-scripts-fs-extra
Dec 27, 2022
Merged

Fix fs-extra usage in scripts#63732
sandersn merged 1 commit intoDefinitelyTyped:masterfrom
remcohaszing:fix-scripts-fs-extra

Conversation

@remcohaszing
Copy link
Copy Markdown
Contributor

fs-extra was not added as a dependency. Scripts that were using fs-extra relied on an indirect dependency on an older version of fs-extra. These scripts only used functions that fs-extra exports from fs. The latest version of fs-extra doesn’t even export these in the ESM export, only in the CJS export. So while my original idea was to update to the latest version of fs-extra, instead I removed the dependency entirely.

Please fill in this template.

`fs-extra` was not added as a dependency. Scripts that were using `fs-extra` relied on an indirect dependency on an
older version of `fs-extra`. These scripts only used functions that `fs-extra` exports from `fs`. The latest version of
`fs-extra` doesn’t even export these in the ESM export, only in the CJS export. So while my original idea was to update
to the latest version of `fs-extra`, instead I removed the dependency entirely.
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Dec 26, 2022

@remcohaszing Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

0 packages in this PR (and infra files)

Code Reviews

There aren't any other owners of this package, so a DT maintainer will review it.

You can test the changes of this PR in the Playground.

Status

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 63732,
  "author": "remcohaszing",
  "headCommitOid": "c6280b02bb009051d0f47971004dbfbd2a50066b",
  "mergeBaseOid": "209ad4dd77c99181de178fba15ad8ff01841b4ef",
  "lastPushDate": "2022-12-26T12:46:31.000Z",
  "lastActivityDate": "2022-12-26T12:47:37.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "scripts/ghostbuster.js",
          "kind": "infrastructure"
        },
        {
          "path": "scripts/update-codeowners.js",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1365145004,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @remcohaszing — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@sandersn sandersn merged commit 1153395 into DefinitelyTyped:master Dec 27, 2022
@remcohaszing remcohaszing deleted the fix-scripts-fs-extra branch February 5, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants