Fix fs-extra usage in scripts#63732
Merged
sandersn merged 1 commit intoDefinitelyTyped:masterfrom Dec 27, 2022
Merged
Conversation
`fs-extra` was not added as a dependency. Scripts that were using `fs-extra` relied on an indirect dependency on an older version of `fs-extra`. These scripts only used functions that `fs-extra` exports from `fs`. The latest version of `fs-extra` doesn’t even export these in the ESM export, only in the CJS export. So while my original idea was to update to the latest version of `fs-extra`, instead I removed the dependency entirely.
Contributor
|
@remcohaszing Thank you for submitting this PR! This is a live comment which I will keep updated. This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this? 0 packages in this PR (and infra files)
Code ReviewsThere aren't any other owners of this package, so a DT maintainer will review it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 63732,
"author": "remcohaszing",
"headCommitOid": "c6280b02bb009051d0f47971004dbfbd2a50066b",
"mergeBaseOid": "209ad4dd77c99181de178fba15ad8ff01841b4ef",
"lastPushDate": "2022-12-26T12:46:31.000Z",
"lastActivityDate": "2022-12-26T12:47:37.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "scripts/ghostbuster.js",
"kind": "infrastructure"
},
{
"path": "scripts/update-codeowners.js",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [],
"mainBotCommentID": 1365145004,
"ciResult": "pass"
} |
Contributor
|
🔔 @remcohaszing — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
sandersn
approved these changes
Dec 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fs-extrawas not added as a dependency. Scripts that were usingfs-extrarelied on an indirect dependency on an older version offs-extra. These scripts only used functions thatfs-extraexports fromfs. The latest version offs-extradoesn’t even export these in the ESM export, only in the CJS export. So while my original idea was to update to the latest version offs-extra, instead I removed the dependency entirely.Please fill in this template.
npm test <package to test>.