Skip to content

Exempt amap-js-api from npm-naming#63747

Merged
sandersn merged 1 commit intomasterfrom
exempt-amap-js-api-npm-naming
Dec 27, 2022
Merged

Exempt amap-js-api from npm-naming#63747
sandersn merged 1 commit intomasterfrom
exempt-amap-js-api-npm-naming

Conversation

@sandersn
Copy link
Copy Markdown
Contributor

@sandersn sandersn commented Dec 27, 2022

Somebody created a bogus amap-js-api package on npm, but it's a mistaken stub. Nothing to do with the types here.

Somebody created a bogus amap-js-api package on npm, but it's a mistaken
stub.
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Dec 27, 2022

@sandersn Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 A DT maintainer needs to approve changes which affect module config files

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 63747,
  "author": "sandersn",
  "headCommitOid": "888c92a994c556111638b7d394870635b1d04ab0",
  "mergeBaseOid": "87ec537dfff5795506076ac1884b5a66c63215dc",
  "lastPushDate": "2022-12-27T21:10:19.000Z",
  "lastActivityDate": "2022-12-27T21:13:11.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "amap-js-api",
      "kind": "edit",
      "files": [
        {
          "path": "types/amap-js-api/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) and not moving towards it (check: `rules`)"
        }
      ],
      "owners": [
        "breeze9527"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1366184588,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Check Config Changes a module config files label Dec 27, 2022
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @breeze9527 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@sandersn sandersn merged commit add5621 into master Dec 27, 2022
@sandersn sandersn deleted the exempt-amap-js-api-npm-naming branch December 27, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Check Config Changes a module config files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants