Skip to content

fix(react-lazy-load-image-component): change Omit key in LazyLoadImageProps#65082

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
jqkk:master
Apr 20, 2023
Merged

fix(react-lazy-load-image-component): change Omit key in LazyLoadImageProps#65082
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
jqkk:master

Conversation

@jqkk
Copy link
Copy Markdown
Contributor

@jqkk jqkk commented Apr 11, 2023

I modified react-lazy-load-image-component package.
I think onLoad rather than onload would be more appropriate.

package url : https://github.com/Aljullu/react-lazy-load-image-component

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change.
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm test <package to test>.
  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

onload -> onLoad
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 11, 2023

@jqkk Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 65082,
  "author": "jqkk",
  "headCommitOid": "0ed33995d05f5b222b3374d261ee2d205dfb48c0",
  "mergeBaseOid": "74f39f2f20779a9668754974fe699c2364393fd7",
  "lastPushDate": "2023-04-11T16:08:06.000Z",
  "lastActivityDate": "2023-04-20T01:15:58.000Z",
  "mergeOfferDate": "2023-04-19T20:52:35.000Z",
  "mergeRequestDate": "2023-04-20T01:15:58.000Z",
  "mergeRequestUser": "jqkk",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "react-lazy-load-image-component",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-lazy-load-image-component/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "danvk",
        "diegochavez",
        "revskill10",
        "kodai3"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "RyanCavanaugh",
      "date": "2023-04-19T20:51:51.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "revskill10",
      "date": "2023-04-12T07:59:25.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1503720225,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels Apr 11, 2023
@typescript-bot
Copy link
Copy Markdown
Contributor

Hey @jqkk,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @danvk @diegochavez @revskill10 @kodai3 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Copy link
Copy Markdown

@revskill10 revskill10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Apr 12, 2023
@typescript-bot
Copy link
Copy Markdown
Contributor

⏳ Hi @jqkk,

It's been a few days since this PR was approved by revskill10 and we're waiting for a DT maintainer to give a review.

If you would like to short-circuit this wait, you can edit some of the test files in the package which verify how the .d.ts files work. This would allow the PR to be merged by you or the DT module owners after a re-review.

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Apr 19, 2023
@typescript-bot
Copy link
Copy Markdown
Contributor

@jqkk: Everything looks good here. I am ready to merge this PR (at 0ed3399) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@danvk, @diegochavez, @revskill10, @kodai3: you can do this too.)

@jqkk
Copy link
Copy Markdown
Contributor Author

jqkk commented Apr 20, 2023

Ready to merge

@typescript-bot typescript-bot merged commit b70c960 into DefinitelyTyped:master Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants