Skip to content

Comments

fix(auth0): made AuthenticationClient members (e.g. oauth) always defined#66393

Merged
typescript-bot merged 5 commits intoDefinitelyTyped:masterfrom
GauBen:master
Sep 20, 2023
Merged

fix(auth0): made AuthenticationClient members (e.g. oauth) always defined#66393
typescript-bot merged 5 commits intoDefinitelyTyped:masterfrom
GauBen:master

Conversation

@GauBen
Copy link
Contributor

@GauBen GauBen commented Aug 16, 2023

Please fill in this template.

If changing an existing definition:

These 5 members are set in the constructor

@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 16, 2023

@GauBen Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Inactive

This PR has been inactive for 8 days.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 66393,
  "author": "GauBen",
  "headCommitOid": "3181a413e1df6841879ffce8933f94d79369712f",
  "mergeBaseOid": "33f592fe24c5bd35395b737ae5d6b64973483eac",
  "lastPushDate": "2023-08-16T09:27:12.000Z",
  "lastActivityDate": "2023-09-20T08:03:08.000Z",
  "mergeOfferDate": "2023-09-11T20:47:19.000Z",
  "mergeRequestDate": "2023-09-20T08:03:08.000Z",
  "mergeRequestUser": "GauBen",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "auth0",
      "kind": "edit",
      "files": [
        {
          "path": "types/auth0/auth0-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/auth0/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/auth0/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "ianhowe76",
        "CatGuardian",
        "MengRS",
        "Scoup",
        "isabela-morais",
        "rbutera",
        "peterblazejewicz",
        "danursin",
        "nhardy",
        "robotastronaut",
        "princefishthrower"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "gabritto",
      "date": "2023-09-11T20:46:31.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1680269128,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels Aug 16, 2023
@typescript-bot
Copy link
Contributor

🔔 @ianhowe76 @CatGuardian @MengRS @Scoup @isabela-morais @rbutera @peterblazejewicz @danursin @nhardy @robotastronaut @princefishthrower — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@GauBen
Copy link
Contributor Author

GauBen commented Aug 16, 2023

I'm not sure I made the right things but I updated tsconfig to match https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#tsconfigjson

@typescript-bot typescript-bot added The CI failed When GH Actions fails and removed Untested Change This PR does not touch tests labels Aug 16, 2023
@typescript-bot
Copy link
Contributor

@GauBen The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@GauBen
Copy link
Contributor Author

GauBen commented Aug 16, 2023

I'm updating the tests rather than the type definition

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Aug 16, 2023
@typescript-bot
Copy link
Contributor

Re-ping @ianhowe76, @CatGuardian, @MengRS, @Scoup, @isabela-morais, @rbutera, @peterblazejewicz, @danursin, @nhardy, @robotastronaut, @princefishthrower:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Aug 27, 2023
@GauBen GauBen mentioned this pull request Sep 1, 2023
@typescript-bot
Copy link
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @GauBen.

(Ping @ianhowe76, @CatGuardian, @MengRS, @Scoup, @isabela-morais, @rbutera, @peterblazejewicz, @danursin, @nhardy, @robotastronaut, @princefishthrower.)

Comment on lines +1160 to +1164
database: DatabaseAuthenticator;
oauth: OAuthAuthenticator;
passwordless: PasswordlessAuthenticator;
tokens: TokensManager;
users: UsersManager;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so those also looks like read-only?, if not available to be set (we've just leaked details in types for no obvious gain for users)

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Sep 11, 2023
@typescript-bot
Copy link
Contributor

@GauBen: Everything looks good here. I am ready to merge this PR (at 3181a41) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@ianhowe76, @CatGuardian, @MengRS, @Scoup, @isabela-morais, @rbutera, @peterblazejewicz, @danursin, @nhardy, @robotastronaut, @princefishthrower: you can do this too.)

@GauBen
Copy link
Contributor Author

GauBen commented Sep 20, 2023

Ready to merge

@typescript-bot typescript-bot merged commit d2fedd8 into DefinitelyTyped:master Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Approved Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants