[@type/react-native-sqlite-storage] change property typo#67062
[@type/react-native-sqlite-storage] change property typo#67062typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom iubns:master
Conversation
fix property name in react native sqlite
|
@iubns Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 67062,
"author": "iubns",
"headCommitOid": "e1fab8e480591b94f2d207ee6b382254f115e7a0",
"mergeBaseOid": "e29db077fbfd08177829fc4cca6750c75999d8f6",
"lastPushDate": "2023-10-15T10:22:45.000Z",
"lastActivityDate": "2023-10-16T17:21:30.000Z",
"mergeOfferDate": "2023-10-16T16:48:59.000Z",
"mergeRequestDate": "2023-10-16T17:21:30.000Z",
"mergeRequestUser": "cavarzan",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "react-native-sqlite-storage",
"kind": "edit",
"files": [
{
"path": "types/react-native-sqlite-storage/index.d.ts",
"kind": "definition"
},
{
"path": "types/react-native-sqlite-storage/react-native-sqlite-storage-tests.ts",
"kind": "test"
}
],
"owners": [
"dryganets",
"cavarzan"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "cavarzan",
"date": "2023-10-16T17:21:14.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "dryganets",
"date": "2023-10-16T16:48:11.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1763346089,
"ciResult": "pass"
} |
|
@iubns Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 67062,
"author": "iubns",
"headCommitOid": "e1fab8e480591b94f2d207ee6b382254f115e7a0",
"mergeBaseOid": "e29db077fbfd08177829fc4cca6750c75999d8f6",
"lastPushDate": "2023-10-15T10:22:45.000Z",
"lastActivityDate": "2023-10-16T17:21:30.000Z",
"mergeOfferDate": "2023-10-16T16:48:59.000Z",
"mergeRequestDate": "2023-10-16T17:21:30.000Z",
"mergeRequestUser": "cavarzan",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "react-native-sqlite-storage",
"kind": "edit",
"files": [
{
"path": "types/react-native-sqlite-storage/index.d.ts",
"kind": "definition"
},
{
"path": "types/react-native-sqlite-storage/react-native-sqlite-storage-tests.ts",
"kind": "test"
}
],
"owners": [
"dryganets",
"cavarzan"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "cavarzan",
"date": "2023-10-16T17:21:14.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "dryganets",
"date": "2023-10-16T16:48:11.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1763346089,
"ciResult": "pass"
} |
|
🔔 @dryganets @cavarzan — please review this PR in the next few days. Be sure to explicitly select |
|
@iubns The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
edit react-native-sqlite-storage-tests for #67062
|
@iubns: Everything looks good here. I am ready to merge this PR (at e1fab8e) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@dryganets, @cavarzan: you can do this too.) |
|
Ready to merge |
fix property name in react native sqlite
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
https://github.com/andpor/react-native-sqlite-storage/blob/b6aeac439b9d038bbb9d2e16812d512c38246775/lib/sqlite.core.js#L107