Skip to content

Conversation

@googlemaps-bot
Copy link
Contributor

This is a automatic pull request to update @types/google.maps

@googlemaps-bot googlemaps-bot force-pushed the chore/sync-google-dot-maps branch from 64f66cc to a145bb7 Compare October 27, 2023 00:15
@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 27, 2023

@googlemaps-bot Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 67209,
  "author": "googlemaps-bot",
  "headCommitOid": "a145bb7c7749b23e78da1abe5c5c0d257d3b2d60",
  "mergeBaseOid": "b0475ac7edca1ce6123f4e255061f97758087c0d",
  "lastPushDate": "2023-10-27T00:15:34.000Z",
  "lastActivityDate": "2023-10-30T23:21:30.000Z",
  "maintainerBlessed": "Waiting for Code Reviews",
  "mergeOfferDate": "2023-10-30T21:09:22.000Z",
  "mergeRequestDate": "2023-10-30T23:21:30.000Z",
  "mergeRequestUser": "wangela",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "google.maps",
      "kind": "edit",
      "files": [
        {
          "path": "types/google.maps/google.maps-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/google.maps/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "amuramoto",
        "wangela"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "wangela",
      "date": "2023-10-30T20:35:28.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1782103466,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @amuramoto @wangela — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Oct 30, 2023
@typescript-bot
Copy link
Contributor

@googlemaps-bot: Everything looks good here. I am ready to merge this PR (at a145bb7) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@amuramoto, @wangela: you can do this too.)

@wangela
Copy link
Contributor

wangela commented Oct 30, 2023

Ready to merge

@typescript-bot typescript-bot merged commit 6db928c into DefinitelyTyped:master Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Critical package Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants