Skip to content

[material-ui-pagination] Stop testing react-dom#68006

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
eps1lon:feat/react-dom/less-integration-testing-split/material-ui-pagination
Dec 29, 2023
Merged

[material-ui-pagination] Stop testing react-dom#68006
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
eps1lon:feat/react-dom/less-integration-testing-split/material-ui-pagination

Conversation

@eps1lon
Copy link
Copy Markdown
Collaborator

@eps1lon eps1lon commented Dec 28, 2023

Usage of react-dom in this package was not actually testing integration between this package and react-dom but react and react-dom. This adds considerable overhead to making changes to react-dom so I just removed these redundant tests.

@eps1lon eps1lon marked this pull request as ready for review December 28, 2023 18:40
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Dec 28, 2023

@eps1lon Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 68006,
  "author": "eps1lon",
  "headCommitOid": "b5f1256ecb002684f475ed27f0430afbef84b764",
  "mergeBaseOid": "79bae95b770c7209689eacc033d93ce9998f4816",
  "lastPushDate": "2023-12-28T18:38:14.000Z",
  "lastActivityDate": "2023-12-28T22:01:57.000Z",
  "mergeOfferDate": "2023-12-28T21:26:12.000Z",
  "mergeRequestDate": "2023-12-28T22:01:57.000Z",
  "mergeRequestUser": "eps1lon",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "material-ui-pagination",
      "kind": "edit",
      "files": [
        {
          "path": "types/material-ui-pagination/material-ui-pagination-tests.tsx",
          "kind": "test"
        },
        {
          "path": "types/material-ui-pagination/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2023-12-28T21:25:29.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1871409135,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the No Other Owners This DT module only has one owner, so we can't have someone verify the change. label Dec 28, 2023
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @eps1lon — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

Copy link
Copy Markdown
Member

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eps1lon 🙇🏻

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Dec 28, 2023
@typescript-bot
Copy link
Copy Markdown
Contributor

@eps1lon: Everything looks good here. I am ready to merge this PR (at b5f1256) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@eps1lon
Copy link
Copy Markdown
Collaborator Author

eps1lon commented Dec 28, 2023

Ready to merge

@typescript-bot typescript-bot merged commit 3d9eac9 into DefinitelyTyped:master Dec 29, 2023
@eps1lon eps1lon deleted the feat/react-dom/less-integration-testing-split/material-ui-pagination branch December 29, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Approved No Other Owners This DT module only has one owner, so we can't have someone verify the change. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants