chore: update yauzl-promise type definitions for v4.0#68631
chore: update yauzl-promise type definitions for v4.0#68631typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
Conversation
3e09c2f to
4c9a304
Compare
|
@RedlineTriad Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 68631,
"author": "RedlineTriad",
"headCommitOid": "e34b9a01ea6bbf3a09c42c9239cdf7fec7976e34",
"mergeBaseOid": "6cb00a7db77b7de0c81cdcc4bfca913c7951cc35",
"lastPushDate": "2024-02-14T16:32:15.000Z",
"lastActivityDate": "2024-02-18T13:53:26.000Z",
"mergeOfferDate": "2024-02-16T20:06:46.000Z",
"mergeRequestDate": "2024-02-18T13:53:26.000Z",
"mergeRequestUser": "RedlineTriad",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "yauzl-promise",
"kind": "edit",
"files": [
{
"path": "types/yauzl-promise/index.d.ts",
"kind": "definition"
},
{
"path": "types/yauzl-promise/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/yauzl-promise/yauzl-promise-tests.ts",
"kind": "test"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2024-02-16T20:06:06.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1944209097,
"ciResult": "pass"
} |
|
🔔 @RedlineTriad — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
|
@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
peterblazejewicz
left a comment
There was a problem hiding this comment.
@RedlineTriad thanks!
|
@RedlineTriad: Everything looks good here. I am ready to merge this PR (at e34b9a0) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
|
Ready to merge |
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
https://github.com/overlookmotel/yauzl-promise/blob/master/README.md?plain=1#L18-L22
package.json.