Skip to content

chore: update yauzl-promise type definitions for v4.0#68631

Merged
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
RedlineTriad:update-yauzl-promise-4.0
Feb 18, 2024
Merged

chore: update yauzl-promise type definitions for v4.0#68631
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
RedlineTriad:update-yauzl-promise-4.0

Conversation

@RedlineTriad
Copy link
Copy Markdown
Contributor

@RedlineTriad RedlineTriad commented Feb 14, 2024

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@RedlineTriad RedlineTriad force-pushed the update-yauzl-promise-4.0 branch 2 times, most recently from 3e09c2f to 4c9a304 Compare February 14, 2024 16:41
@RedlineTriad RedlineTriad marked this pull request as ready for review February 14, 2024 16:43
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Feb 14, 2024

@RedlineTriad Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 68631,
  "author": "RedlineTriad",
  "headCommitOid": "e34b9a01ea6bbf3a09c42c9239cdf7fec7976e34",
  "mergeBaseOid": "6cb00a7db77b7de0c81cdcc4bfca913c7951cc35",
  "lastPushDate": "2024-02-14T16:32:15.000Z",
  "lastActivityDate": "2024-02-18T13:53:26.000Z",
  "mergeOfferDate": "2024-02-16T20:06:46.000Z",
  "mergeRequestDate": "2024-02-18T13:53:26.000Z",
  "mergeRequestUser": "RedlineTriad",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "yauzl-promise",
      "kind": "edit",
      "files": [
        {
          "path": "types/yauzl-promise/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/yauzl-promise/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/yauzl-promise/yauzl-promise-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2024-02-16T20:06:06.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1944209097,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the No Other Owners This DT module only has one owner, so we can't have someone verify the change. label Feb 14, 2024
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @RedlineTriad — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot
Copy link
Copy Markdown
Contributor

@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

Copy link
Copy Markdown
Member

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RedlineTriad thanks!

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Feb 16, 2024
@typescript-bot
Copy link
Copy Markdown
Contributor

@RedlineTriad: Everything looks good here. I am ready to merge this PR (at e34b9a0) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@RedlineTriad
Copy link
Copy Markdown
Contributor Author

Ready to merge

@typescript-bot typescript-bot merged commit 6e457e3 into DefinitelyTyped:master Feb 18, 2024
@RedlineTriad RedlineTriad deleted the update-yauzl-promise-4.0 branch February 18, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Approved No Other Owners This DT module only has one owner, so we can't have someone verify the change. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants