chore: sync updates to google.maps#69747
chore: sync updates to google.maps#69747typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
|
@googlemaps-bot Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69747,
"author": "googlemaps-bot",
"headCommitOid": "e234dbcb30a91a9e55bc57467285734419ea05e4",
"mergeBaseOid": "e40cab53d9971a3e0b34e8fb18ece74240d9425d",
"lastPushDate": "2024-06-04T18:52:50.000Z",
"lastActivityDate": "2024-06-17T22:07:30.000Z",
"mergeOfferDate": "2024-06-17T22:05:22.000Z",
"mergeRequestDate": "2024-06-17T22:07:30.000Z",
"mergeRequestUser": "kwnevarez",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "google.maps",
"kind": "edit",
"files": [
{
"path": "types/google.maps/google.maps-tests.ts",
"kind": "test"
},
{
"path": "types/google.maps/index.d.ts",
"kind": "definition"
}
],
"owners": [
"kwnevarez",
"wangela"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "sandersn",
"date": "2024-06-17T22:04:44.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "kwnevarez",
"date": "2024-06-04T20:19:17.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 2148195848,
"ciResult": "pass"
} |
|
🔔 @kwnevarez @wangela — please review this PR in the next few days. Be sure to explicitly select |
|
Hello there! thanks for the types, great job. I would like to contribute but I am not really sure how. I don't even know if this will be read by a human as I guess most interactions in this thread are robots. Should I make a fork for the entire thing if all I want to add is one line? |
|
Re-ping @wangela: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
|
@googlemaps-bot: Everything looks good here. I am ready to merge this PR (at e234dbc) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@kwnevarez, @wangela: you can do this too.) |
|
Ready to merge |
This is a automatic pull request to update @types/google.maps