Bump version of k6 to v0.53#70239
Conversation
55eb7c6 to
e007a53
Compare
a1b4bce to
390a29c
Compare
|
@mstoykov Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PR
Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 70239,
"author": "mstoykov",
"headCommitOid": "cadd8e744b349f2d58e2ac410be22fe0b895a7da",
"mergeBaseOid": "c96a6ed9505d55f36f457b89ca4b3f53a69024a7",
"lastPushDate": "2024-08-07T12:14:53.000Z",
"lastActivityDate": "2024-08-13T10:17:04.000Z",
"mergeOfferDate": "2024-08-13T09:14:01.000Z",
"mergeRequestDate": "2024-08-13T10:17:04.000Z",
"mergeRequestUser": "mstoykov",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "k6",
"kind": "edit",
"files": [
{
"path": "types/k6/crypto.d.ts",
"kind": "definition"
},
{
"path": "types/k6/experimental/websockets.d.ts",
"kind": "definition"
},
{
"path": "types/k6/global.d.ts",
"kind": "definition"
},
{
"path": "types/k6/http.d.ts",
"kind": "definition"
},
{
"path": "types/k6/index.d.ts",
"kind": "definition"
},
{
"path": "types/k6/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/k6/test/crypto.ts",
"kind": "test"
},
{
"path": "types/k6/test/global.ts",
"kind": "test"
},
{
"path": "types/k6/test/http.ts",
"kind": "test"
},
{
"path": "types/k6/test/websockets.ts",
"kind": "test"
}
],
"owners": [
"MStoykov",
"codebien",
"oleiade",
"olegbespalov",
"nicolevanderhoeven",
"ankur22",
"inancgumus",
"ka3de",
"joanlopez"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "joanlopez",
"date": "2024-08-13T09:28:49.000Z",
"isMaintainer": false
},
{
"type": "approved",
"reviewer": "codebien",
"date": "2024-08-13T09:13:25.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 2285628584,
"ciResult": "pass"
} |
|
🔔 @codebien @oleiade @olegbespalov @nicolevanderhoeven @ankur22 @inancgumus @ka3de @joanlopez — please review this PR in the next few days. Be sure to explicitly select |
390a29c to
e111537
Compare
|
@mstoykov The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
16aa340 to
cadd8e7
Compare
|
@codebien Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
@mstoykov: Everything looks good here. I am ready to merge this PR (at cadd8e7) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@codebien, @oleiade, @olegbespalov, @nicolevanderhoeven, @ankur22, @inancgumus, @ka3de, @joanlopez: you can do this too.) |
|
Ready to merge |
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.If changing an existing definition:
package.json.If removing a declaration:
notNeededPackages.json.