Skip to content

Bump version of k6 to v0.53#70239

Merged
typescript-bot merged 3 commits intoDefinitelyTyped:masterfrom
grafana:release-v0.53.0
Aug 13, 2024
Merged

Bump version of k6 to v0.53#70239
typescript-bot merged 3 commits intoDefinitelyTyped:masterfrom
grafana:release-v0.53.0

Conversation

@mstoykov
Copy link
Copy Markdown
Contributor

@mstoykov mstoykov commented Aug 7, 2024

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@mstoykov mstoykov marked this pull request as ready for review August 13, 2024 08:10
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Aug 13, 2024

@mstoykov Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 70239,
  "author": "mstoykov",
  "headCommitOid": "cadd8e744b349f2d58e2ac410be22fe0b895a7da",
  "mergeBaseOid": "c96a6ed9505d55f36f457b89ca4b3f53a69024a7",
  "lastPushDate": "2024-08-07T12:14:53.000Z",
  "lastActivityDate": "2024-08-13T10:17:04.000Z",
  "mergeOfferDate": "2024-08-13T09:14:01.000Z",
  "mergeRequestDate": "2024-08-13T10:17:04.000Z",
  "mergeRequestUser": "mstoykov",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "k6",
      "kind": "edit",
      "files": [
        {
          "path": "types/k6/crypto.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/k6/experimental/websockets.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/k6/global.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/k6/http.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/k6/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/k6/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/k6/test/crypto.ts",
          "kind": "test"
        },
        {
          "path": "types/k6/test/global.ts",
          "kind": "test"
        },
        {
          "path": "types/k6/test/http.ts",
          "kind": "test"
        },
        {
          "path": "types/k6/test/websockets.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "MStoykov",
        "codebien",
        "oleiade",
        "olegbespalov",
        "nicolevanderhoeven",
        "ankur22",
        "inancgumus",
        "ka3de",
        "joanlopez"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "joanlopez",
      "date": "2024-08-13T09:28:49.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "codebien",
      "date": "2024-08-13T09:13:25.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2285628584,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Author is Owner The author of this PR is a listed owner of the package. labels Aug 13, 2024
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @codebien @oleiade @olegbespalov @nicolevanderhoeven @ankur22 @inancgumus @ka3de @joanlopez — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner The CI failed When GH Actions fails and removed Self Merge This PR can now be self-merged by the PR author or an owner Owner Approved A listed owner of this package signed off on the pull request. labels Aug 13, 2024
@typescript-bot
Copy link
Copy Markdown
Contributor

@mstoykov The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Aug 13, 2024
@typescript-bot
Copy link
Copy Markdown
Contributor

@codebien Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Aug 13, 2024
@typescript-bot
Copy link
Copy Markdown
Contributor

@mstoykov: Everything looks good here. I am ready to merge this PR (at cadd8e7) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@codebien, @oleiade, @olegbespalov, @nicolevanderhoeven, @ankur22, @inancgumus, @ka3de, @joanlopez: you can do this too.)

@mstoykov
Copy link
Copy Markdown
Contributor Author

Ready to merge

@typescript-bot typescript-bot merged commit d6069f2 into DefinitelyTyped:master Aug 13, 2024
@mstoykov mstoykov deleted the release-v0.53.0 branch September 17, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants