Skip to content

add new owner#70375

Merged
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
zkrige:patch-1
Aug 24, 2024
Merged

add new owner#70375
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
zkrige:patch-1

Conversation

@zkrige
Copy link
Copy Markdown
Contributor

@zkrige zkrige commented Aug 24, 2024

adding a new owner to nw.js as per #70077 (reply in thread)

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Aug 24, 2024

@zkrige Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 70375,
  "author": "zkrige",
  "headCommitOid": "3adbfc299f3fc50270cf44e2db7b9ec301007803",
  "mergeBaseOid": "378df05f9be65af6e865b4334a1b6e3bb0247ef7",
  "lastPushDate": "2024-08-24T09:40:52.000Z",
  "lastActivityDate": "2024-08-24T11:03:28.000Z",
  "mergeOfferDate": "2024-08-24T11:02:31.000Z",
  "mergeRequestDate": "2024-08-24T11:03:28.000Z",
  "mergeRequestUser": "ayushmanchhabra",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "nw.js",
      "kind": "edit",
      "files": [
        {
          "path": "types/nw.js/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "AyushmanChhabra"
      ],
      "addedOwners": [
        "zkrige"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "ayushmanchhabra",
      "date": "2024-08-24T11:01:55.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2308273533,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Edits Owners This PR adds or removes owners label Aug 24, 2024
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @ayushmanchhabra — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Aug 24, 2024
@typescript-bot
Copy link
Copy Markdown
Contributor

@zkrige: Everything looks good here. I am ready to merge this PR (at 3adbfc2) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@ayushmanchhabra: you can do this too.)

@ayushmanchhabra
Copy link
Copy Markdown
Contributor

Ready to merge

@typescript-bot typescript-bot merged commit 366ac99 into DefinitelyTyped:master Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Edits Owners This PR adds or removes owners Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants