Skip to content

fix(moment-precise-range-plugin): bump version, modify tests#71074

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
hkleungai:moment-precise-range-plugin-fix
Nov 11, 2024
Merged

fix(moment-precise-range-plugin): bump version, modify tests#71074
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
hkleungai:moment-precise-range-plugin-fix

Conversation

@hkleungai
Copy link
Copy Markdown
Contributor

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Nov 3, 2024

@hkleungai Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 71074,
  "author": "hkleungai",
  "headCommitOid": "c8d0ea9fee8f9f6ba09101bfeb7111ae717b5a88",
  "mergeBaseOid": "c14379399801779d4dc9c1e48c1515a9f6eec37c",
  "lastPushDate": "2024-11-03T13:20:17.000Z",
  "lastActivityDate": "2024-11-11T17:59:36.000Z",
  "mergeOfferDate": "2024-11-11T17:56:47.000Z",
  "mergeRequestDate": "2024-11-11T17:59:36.000Z",
  "mergeRequestUser": "hkleungai",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "attw.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical",
      "isSafeInfrastructureEdit": true
    },
    {
      "name": "moment-precise-range-plugin",
      "kind": "edit",
      "files": [
        {
          "path": "types/moment-precise-range-plugin/moment-precise-range-plugin-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/moment-precise-range-plugin/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "gricey432"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "andrewbranch",
      "date": "2024-11-11T17:56:10.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2453426191,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @gricey432 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label Nov 5, 2024
@typescript-bot
Copy link
Copy Markdown
Contributor

@hkleungai Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

@hkleungai hkleungai force-pushed the moment-precise-range-plugin-fix branch from dcf86ba to c8d0ea9 Compare November 8, 2024 17:59
@typescript-bot typescript-bot removed the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label Nov 8, 2024
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Nov 11, 2024
@typescript-bot
Copy link
Copy Markdown
Contributor

@hkleungai: Everything looks good here. I am ready to merge this PR (at c8d0ea9) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@gricey432: you can do this too.)

@hkleungai
Copy link
Copy Markdown
Contributor Author

Ready to merge

@typescript-bot typescript-bot merged commit aaafadd into DefinitelyTyped:master Nov 11, 2024
@hkleungai hkleungai deleted the moment-precise-range-plugin-fix branch December 15, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants