Skip to content

[@babel/traverse]: Add support for recursive NodePath::get(…) calls#72228

Merged
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
ExE-Boss:types/babel-traverse/recursive-get-method
Mar 26, 2025
Merged

[@babel/traverse]: Add support for recursive NodePath::get(…) calls#72228
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
ExE-Boss:types/babel-traverse/recursive-get-method

Conversation

@ExE-Boss
Copy link
Copy Markdown
Contributor

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

Footnotes

  1. Note that @babel/traverse’s internal type definitions don’t support strictNullChecks.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Mar 18, 2025

@ExE-Boss Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 72228,
  "author": "ExE-Boss",
  "headCommitOid": "112ad8bc768f7e7f18019749361fc49002437bbd",
  "mergeBaseOid": "5c6992901c82e5061bb60c0a8d746d9015793c02",
  "lastPushDate": "2025-03-18T17:55:34.000Z",
  "lastActivityDate": "2025-03-26T07:44:18.000Z",
  "mergeOfferDate": "2025-03-25T16:04:48.000Z",
  "mergeRequestDate": "2025-03-26T07:44:18.000Z",
  "mergeRequestUser": "ExE-Boss",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "babel__traverse",
      "kind": "edit",
      "files": [
        {
          "path": "types/babel__traverse/babel__traverse-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/babel__traverse/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "yortus",
        "marvinhagemeister",
        "rpetrich",
        "mgroenhoff",
        "dlgrit",
        "ifiokjr",
        "ExE-Boss",
        "danez"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "rbuckton",
      "date": "2025-03-25T16:04:08.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2734231744,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Author is Owner The author of this PR is a listed owner of the package. labels Mar 18, 2025
@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Mar 18, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @yortus @marvinhagemeister @rpetrich @mgroenhoff @dlgrit @ifiokjr @danez — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Mar 18, 2025
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in Pull Request Status Board Mar 18, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Mar 18, 2025
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Mar 25, 2025
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in Pull Request Status Board Mar 25, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

@ExE-Boss: Everything looks good here. I am ready to merge this PR (at 112ad8b) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@yortus, @marvinhagemeister, @rpetrich, @mgroenhoff, @dlgrit, @ifiokjr, @danez: you can do this too.)

@ExE-Boss
Copy link
Copy Markdown
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Mar 26, 2025
@typescript-bot typescript-bot merged commit a645f15 into DefinitelyTyped:master Mar 26, 2025
4 checks passed
@ExE-Boss ExE-Boss deleted the types/babel-traverse/recursive-get-method branch March 26, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. Critical package Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants