Skip to content

feat(subtitle): remove types#72350

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
hkleungai:subtitle-removal
Apr 2, 2025
Merged

feat(subtitle): remove types#72350
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
hkleungai:subtitle-removal

Conversation

@hkleungai
Copy link
Copy Markdown
Contributor

See this commit.

Release 3.0.0

  • rewrite project with typescript

Please fill in this template.

Select one of these and delete the others:

If removing a declaration:

  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 1, 2025

@hkleungai Thank you for submitting this PR!

This is a live comment that I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

1 package in this PR (and infra files)

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer needs to approve changes that affect DT infrastructure (notNeededPackages.json)

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 72350,
  "author": "hkleungai",
  "headCommitOid": "9a66385baad2e61ae0b6726fde3252a78650a9d3",
  "mergeBaseOid": "b6b5eb1c46742c1e63359927b1706211602dcd05",
  "lastPushDate": "2025-04-01T17:42:59.000Z",
  "lastActivityDate": "2025-04-02T02:07:00.000Z",
  "mergeOfferDate": "2025-04-01T21:24:40.000Z",
  "mergeRequestDate": "2025-04-02T02:07:00.000Z",
  "mergeRequestUser": "hkleungai",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "notNeededPackages.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical",
      "isSafeInfrastructureEdit": false
    },
    {
      "name": "subtitle",
      "kind": "delete",
      "files": [
        {
          "path": "types/subtitle/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/subtitle/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/subtitle/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/subtitle/subtitle-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/subtitle/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "jenglamlow"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2025-04-01T21:24:03.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2770229131,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @jenglamlow — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Apr 1, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in Pull Request Status Board Apr 1, 2025
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Apr 1, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

@hkleungai: Everything looks good here. I am ready to merge this PR (at 9a66385) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@jenglamlow: you can do this too.)

@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in Pull Request Status Board Apr 1, 2025
@hkleungai
Copy link
Copy Markdown
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Apr 2, 2025
@typescript-bot typescript-bot merged commit 065b4f4 into DefinitelyTyped:master Apr 2, 2025
4 checks passed
@hkleungai hkleungai deleted the subtitle-removal branch April 2, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Edits Infrastructure Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants