Skip to content

[office-js][office-js-preview] (Outlook) Clarify support for the Notification API in Outlook on mobile#72453

Merged
Rick-Kirkham merged 3 commits intoDefinitelyTyped:masterfrom
samantharamon:office-js-notifications-mobile
Apr 14, 2025
Merged

[office-js][office-js-preview] (Outlook) Clarify support for the Notification API in Outlook on mobile#72453
Rick-Kirkham merged 3 commits intoDefinitelyTyped:masterfrom
samantharamon:office-js-notifications-mobile

Conversation

@samantharamon
Copy link
Copy Markdown
Contributor

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: None
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 10, 2025

@samantharamon Thank you for submitting this PR!

This is a live comment that I will keep updated.

2 packages in this PR

Code Reviews

Because this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 A DT maintainer needs to approve changes that affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 72453,
  "author": "samantharamon",
  "headCommitOid": "4980d91c3143036ef39bf1a05d4dcb3a68e0dd23",
  "mergeBaseOid": "41f9ff2256002fbe7d88b782cb908106441dd3e2",
  "lastPushDate": "2025-04-10T00:34:25.000Z",
  "lastActivityDate": "2025-04-14T17:49:40.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "office-js-preview",
      "kind": "edit",
      "files": [
        {
          "path": "types/office-js-preview/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "OfficeDev",
        "Rick-Kirkham",
        "AlexJerabek",
        "ElizabethSamuel-MSFT",
        "alison-mk",
        "samantharamon"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "office-js",
      "kind": "edit",
      "files": [
        {
          "path": "types/office-js/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "OfficeDev",
        "Rick-Kirkham",
        "AlexJerabek",
        "ElizabethSamuel-MSFT",
        "alison-mk",
        "samantharamon"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "stale",
      "reviewer": "Rick-Kirkham",
      "date": "2025-04-10T00:44:35.000Z",
      "abbrOid": "9516be2"
    }
  ],
  "mainBotCommentID": 2791263767,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Edits multiple packages Author is Owner The author of this PR is a listed owner of the package. Untested Change This PR does not touch tests labels Apr 10, 2025
@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Apr 10, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @OfficeDev @Rick-Kirkham @AlexJerabek @ElizabethSamuel-MSFT @alison-mk — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Apr 10, 2025
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Apr 10, 2025
@typescript-bot typescript-bot removed the Owner Approved A listed owner of this package signed off on the pull request. label Apr 10, 2025
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in Pull Request Status Board Apr 10, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Apr 10, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

@Rick-Kirkham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in Pull Request Status Board Apr 10, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Apr 10, 2025
@samantharamon
Copy link
Copy Markdown
Contributor Author

@Rick-Kirkham when you get a chance, could you please merge this DT PR? Thanks!

@Rick-Kirkham Rick-Kirkham merged commit 74fc4fc into DefinitelyTyped:master Apr 14, 2025
4 checks passed
@samantharamon samantharamon deleted the office-js-notifications-mobile branch April 14, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. Edits multiple packages Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants