[openui5] Update the definition files for OpenUI5 1.135#72647
[openui5] Update the definition files for OpenUI5 1.135#72647typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
|
@akudev Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PR
Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 72647,
"author": "akudev",
"headCommitOid": "442c3c035cbd6063db74e81fd6fac2b1d59d183a",
"mergeBaseOid": "29e1a22913cb2a68eae479bd6e8b1964c5c13613",
"lastPushDate": "2025-04-29T14:26:52.000Z",
"lastActivityDate": "2025-04-29T15:23:02.000Z",
"mergeOfferDate": "2025-04-29T14:58:25.000Z",
"mergeRequestDate": "2025-04-29T15:23:02.000Z",
"mergeRequestUser": "akudev",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "openui5",
"kind": "edit",
"files": [
{
"path": "types/openui5/openui5-tests.ts",
"kind": "test"
},
{
"path": "types/openui5/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/openui5/sap.f.d.ts",
"kind": "definition"
},
{
"path": "types/openui5/sap.m.d.ts",
"kind": "definition"
},
{
"path": "types/openui5/sap.tnt.d.ts",
"kind": "definition"
},
{
"path": "types/openui5/sap.ui.codeeditor.d.ts",
"kind": "definition"
},
{
"path": "types/openui5/sap.ui.commons.d.ts",
"kind": "definition"
},
{
"path": "types/openui5/sap.ui.core.d.ts",
"kind": "definition"
},
{
"path": "types/openui5/sap.ui.dt.d.ts",
"kind": "definition"
},
{
"path": "types/openui5/sap.ui.fl.d.ts",
"kind": "definition"
},
{
"path": "types/openui5/sap.ui.integration.d.ts",
"kind": "definition"
},
{
"path": "types/openui5/sap.ui.layout.d.ts",
"kind": "definition"
},
{
"path": "types/openui5/sap.ui.mdc.d.ts",
"kind": "definition"
},
{
"path": "types/openui5/sap.ui.rta.d.ts",
"kind": "definition"
},
{
"path": "types/openui5/sap.ui.suite.d.ts",
"kind": "definition"
},
{
"path": "types/openui5/sap.ui.support.d.ts",
"kind": "definition"
},
{
"path": "types/openui5/sap.ui.table.d.ts",
"kind": "definition"
},
{
"path": "types/openui5/sap.ui.testrecorder.d.ts",
"kind": "definition"
},
{
"path": "types/openui5/sap.ui.unified.d.ts",
"kind": "definition"
},
{
"path": "types/openui5/sap.ui.ux3.d.ts",
"kind": "definition"
},
{
"path": "types/openui5/sap.ui.webc.common.d.ts",
"kind": "definition"
},
{
"path": "types/openui5/sap.ui.webc.fiori.d.ts",
"kind": "definition"
},
{
"path": "types/openui5/sap.ui.webc.main.d.ts",
"kind": "definition"
},
{
"path": "types/openui5/sap.uxap.d.ts",
"kind": "definition"
}
],
"owners": [
"openui5bot",
"petermuessig",
"codeworrior",
"akudev"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "petermuessig",
"date": "2025-04-29T14:57:46.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 2839145555,
"ciResult": "pass"
} |
|
🔔 @openui5bot @petermuessig @codeworrior — please review this PR in the next few days. Be sure to explicitly select |
petermuessig
left a comment
There was a problem hiding this comment.
LGTM, although the deprecation of the IToolHeader interface looked suspicious at the first look. But as the IToolPage now accepts Control as header, the ShellBar doesn't need that marker interface anymore.
|
@akudev: Everything looks good here. I am ready to merge this PR (at 442c3c0) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@openui5bot, @petermuessig, @codeworrior: you can do this too.) |
|
Ready to merge |
pnpm test <package to test>.If changing an existing definition: