Skip to content

[@vimeo/vimeo] Add Promise API#72729

Merged
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
MysteryBlokHed:@vimeo/vimeo/add-promise-api
May 19, 2025
Merged

[@vimeo/vimeo] Add Promise API#72729
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
MysteryBlokHed:@vimeo/vimeo/add-promise-api

Conversation

@MysteryBlokHed
Copy link
Copy Markdown
Contributor

Related comments/issues: #69141 (comment), vimeo/vimeo.js#42 (comment)

If changing an existing definition:

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented May 8, 2025

@MysteryBlokHed Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 72729,
  "author": "MysteryBlokHed",
  "headCommitOid": "5c58cfb20820d901fa0d9c4d2e42725c95504c53",
  "mergeBaseOid": "a3b1f8fcebbe9260649accf77e5830eccd45b974",
  "lastPushDate": "2025-05-08T15:24:13.000Z",
  "lastActivityDate": "2025-05-19T20:41:35.000Z",
  "mergeOfferDate": "2025-05-19T05:10:33.000Z",
  "mergeRequestDate": "2025-05-19T20:41:35.000Z",
  "mergeRequestUser": "MysteryBlokHed",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "vimeo__vimeo",
      "kind": "edit",
      "files": [
        {
          "path": "types/vimeo__vimeo/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/vimeo__vimeo/vimeo__vimeo-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "MysteryBlokHed"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "henrik-lindgren",
      "date": "2025-05-19T05:09:54.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2863451047,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Author is Owner The author of this PR is a listed owner of the package. No Other Owners This DT module only has one owner, so we can't have someone verify the change. labels May 8, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @MysteryBlokHed — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

Comment thread types/vimeo__vimeo/index.d.ts Outdated
@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label May 15, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in Pull Request Status Board May 15, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

@MysteryBlokHed One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@typescript-bot typescript-bot removed the Revision needed This PR needs code changes before it can be merged. label May 16, 2025
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in Pull Request Status Board May 16, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

@henrik-lindgren Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner labels May 19, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in Pull Request Status Board May 19, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

@MysteryBlokHed: Everything looks good here. I am ready to merge this PR (at 5c58cfb) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@MysteryBlokHed
Copy link
Copy Markdown
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board May 19, 2025
@typescript-bot typescript-bot merged commit 2818ad9 into DefinitelyTyped:master May 19, 2025
4 checks passed
@MysteryBlokHed MysteryBlokHed deleted the @vimeo/vimeo/add-promise-api branch June 29, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. No Other Owners This DT module only has one owner, so we can't have someone verify the change. Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants