[@vimeo/vimeo] Add Promise API#72729
Conversation
|
@MysteryBlokHed Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 72729,
"author": "MysteryBlokHed",
"headCommitOid": "5c58cfb20820d901fa0d9c4d2e42725c95504c53",
"mergeBaseOid": "a3b1f8fcebbe9260649accf77e5830eccd45b974",
"lastPushDate": "2025-05-08T15:24:13.000Z",
"lastActivityDate": "2025-05-19T20:41:35.000Z",
"mergeOfferDate": "2025-05-19T05:10:33.000Z",
"mergeRequestDate": "2025-05-19T20:41:35.000Z",
"mergeRequestUser": "MysteryBlokHed",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "vimeo__vimeo",
"kind": "edit",
"files": [
{
"path": "types/vimeo__vimeo/index.d.ts",
"kind": "definition"
},
{
"path": "types/vimeo__vimeo/vimeo__vimeo-tests.ts",
"kind": "test"
}
],
"owners": [
"MysteryBlokHed"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "henrik-lindgren",
"date": "2025-05-19T05:09:54.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 2863451047,
"ciResult": "pass"
} |
|
🔔 @MysteryBlokHed — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
|
@MysteryBlokHed One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
|
@henrik-lindgren Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
@MysteryBlokHed: Everything looks good here. I am ready to merge this PR (at 5c58cfb) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
|
Ready to merge |
Related comments/issues: #69141 (comment), vimeo/vimeo.js#42 (comment)
pnpm test <package to test>.If changing an existing definition:
Promise return values can be seen in https://github.com/vimeo/vimeo.js/blob/fdd3f481761aae289721b50c4afa17970a410eda/lib/vimeo.js
package.json.