Skip to content

[react-router-bootstrap] Fix tests#72831

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
eps1lon:fixreactfriends
May 21, 2025
Merged

[react-router-bootstrap] Fix tests#72831
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
eps1lon:fixreactfriends

Conversation

@eps1lon
Copy link
Copy Markdown
Collaborator

@eps1lon eps1lon commented May 20, 2025

<2 matches @types/react-bootstrap@1.1.0 which is just a stub package without type definitions thus breaking tests: https://github.com/DefinitelyTyped/DefinitelyTyped/actions/runs/15117687651/job/42492494543?pr=72826

@typescript-bot typescript-bot moved this to Needs Author Action in Pull Request Status Board May 20, 2025
@eps1lon eps1lon marked this pull request as ready for review May 20, 2025 12:41
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented May 20, 2025

@eps1lon Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 72831,
  "author": "eps1lon",
  "headCommitOid": "595c1ef19fc5f5094ece1e9a3fc925a0073ce6eb",
  "mergeBaseOid": "981449c691b9be0fca569c48151fc57606f5ea7a",
  "lastPushDate": "2025-05-20T12:40:49.000Z",
  "lastActivityDate": "2025-05-21T09:16:55.000Z",
  "mergeOfferDate": "2025-05-20T23:25:26.000Z",
  "mergeRequestDate": "2025-05-21T09:16:55.000Z",
  "mergeRequestUser": "eps1lon",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "react-router-bootstrap",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-router-bootstrap/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "vlesierse",
        "LKay",
        "olmobrutall",
        "maxerenberg"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "MysteryBlokHed",
      "date": "2025-05-20T23:24:49.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2894262850,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @vlesierse @LKay @olmobrutall @maxerenberg — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in Pull Request Status Board May 20, 2025
@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner labels May 20, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

@eps1lon: Everything looks good here. I am ready to merge this PR (at 595c1ef) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@vlesierse, @LKay, @olmobrutall, @maxerenberg: you can do this too.)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in Pull Request Status Board May 20, 2025
@eps1lon
Copy link
Copy Markdown
Collaborator Author

eps1lon commented May 21, 2025

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board May 21, 2025
@typescript-bot typescript-bot merged commit 58fe2ba into DefinitelyTyped:master May 21, 2025
4 checks passed
@eps1lon eps1lon deleted the fixreactfriends branch May 21, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants