Update for IMA v3.697.0#72898
Update for IMA v3.697.0#72898typescript-bot merged 13 commits intoDefinitelyTyped:masterfrom Kiro705:update
Conversation
Updates branch to DefinitelyTyped head.
Merge DefinitelyType head changes.
|
@Kiro705 Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 72898,
"author": "Kiro705",
"headCommitOid": "6279ea6439924ca62a67f7bdb166805794e50bbd",
"mergeBaseOid": "f2fcf51a0c379dc8daca803be36df971c14d5078",
"lastPushDate": "2025-05-29T16:00:57.000Z",
"lastActivityDate": "2025-06-04T13:46:52.000Z",
"mergeOfferDate": "2025-06-03T17:13:20.000Z",
"mergeRequestDate": "2025-06-04T13:46:52.000Z",
"mergeRequestUser": "Kiro705",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "google_interactive_media_ads_types",
"kind": "edit",
"files": [
{
"path": "types/google_interactive_media_ads_types/index.d.ts",
"kind": "definition"
},
{
"path": "types/google_interactive_media_ads_types/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"Kiro705",
"gschoppe"
],
"addedOwners": [],
"deletedOwners": [
"gschoppe"
],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "jakebailey",
"date": "2025-06-03T17:12:41.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2919866250,
"ciResult": "pass"
} |
|
🔔 @Kiro705 — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
|
@Kiro705 Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day! |
|
Hey @Kiro705, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
|
🔔 @gschoppe — please review this PR in the next few days. Be sure to explicitly select |
| "name": "@types/google_interactive_media_ads_types", | ||
| "nonNpm": true, | ||
| "nonNpmDescription": "Google Interactive Media Ads HTML5 SDK", | ||
| "version": "1.20241219.9999", |
There was a problem hiding this comment.
This versioning goes backwards and so nobody will get this update. Did you mean to set a different version?
There was a problem hiding this comment.
Yes, the version should change. In the initial release I mistakenly used the date to create the version number, but I think it makes more sense to match this version number to the IMA SDK version number (https://developers.google.com/interactive-media-ads/docs/sdks/html5/client-side/history)
Would it be reasonable to instead change the major number as well, so the new version would be "2.36970.9999"?
Open to other suggestions as well.
There was a problem hiding this comment.
Yes. You'd have to bump the major.
There was a problem hiding this comment.
Thanks, I updated the version to 2.36970.9999. Moving forward, the version number will continue to match the latest IMA SDK version number.
There was a problem hiding this comment.
Seems fine, but why not just 3.697?
There was a problem hiding this comment.
I ask mainly because you've mapped 3.697.0 to 36970, which if bumped according to semver on your side, could turn into 3.697.10, so 369710, which would be out of order again when 3.698.0 comes around again and is mapped to 36980. It seems like it would make more sense to just have the types version match your package's version?
There was a problem hiding this comment.
I could do that as well. The IMA SDK version is 3.697.0, would it make more sense to use 3.6970.9999 for the type definition version?
There was a problem hiding this comment.
3.697.9999 would make the most sense, as it's unlikely a patch version would change an API. This is how regular npm packages are tracked (as they have semver versions too).
There was a problem hiding this comment.
Sounds good, I'll update it to 3.697.9999. I agree that patch version can be ignored since it shouldn't change the APIs. Thanks for the help.
|
@Kiro705 One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
|
@jakebailey Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
@Kiro705: Everything looks good here. I am ready to merge this PR (at 6279ea6) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@gschoppe: you can do this too.) |
|
Ready to merge |
Updates google_interactive_media_ads_types for version IMA SDK v3.697.0.
Changes:
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
package.json.