Skip to content

feat(flatbuffers): remove types#72934

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
hkleungai:flatbuffers-removal
Jun 4, 2025
Merged

feat(flatbuffers): remove types#72934
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
hkleungai:flatbuffers-removal

Conversation

@hkleungai
Copy link
Copy Markdown
Contributor

See https://github.com/google/flatbuffers/releases/tag/v2.0.0.

  • Overhaul of TypeScript support.

Please fill in this template.

Select one of these and delete the others:

If removing a declaration:

  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jun 2, 2025

@hkleungai Thank you for submitting this PR!

This is a live comment that I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

1 package in this PR (and infra files)

Code Reviews

There aren't any other owners of this package, so a DT maintainer will review it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer needs to approve changes that affect DT infrastructure (notNeededPackages.json)

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 72934,
  "author": "hkleungai",
  "headCommitOid": "27319ec14d02bda3a6a67ee1c09ec9fd10a8d0bc",
  "mergeBaseOid": "971d81fa89ecb53a034bbfd374ce8a5961a9f712",
  "lastPushDate": "2025-06-02T18:33:26.000Z",
  "lastActivityDate": "2025-06-04T02:15:42.000Z",
  "mergeOfferDate": "2025-06-03T15:50:48.000Z",
  "mergeRequestDate": "2025-06-04T02:15:42.000Z",
  "mergeRequestUser": "hkleungai",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "notNeededPackages.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical",
      "isSafeInfrastructureEdit": false
    },
    {
      "name": "flatbuffers",
      "kind": "delete",
      "files": [
        {
          "path": "types/flatbuffers/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/flatbuffers/flatbuffers-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/flatbuffers/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/flatbuffers/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/flatbuffers/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "sandersn",
      "date": "2025-06-03T15:50:08.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2931976133,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Edits Infrastructure No Other Owners This DT module only has one owner, so we can't have someone verify the change. labels Jun 2, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @hkleungai — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Jun 2, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in Pull Request Status Board Jun 2, 2025
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Jun 3, 2025
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in Pull Request Status Board Jun 3, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

@hkleungai: Everything looks good here. I am ready to merge this PR (at 27319ec) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@hkleungai
Copy link
Copy Markdown
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Jun 4, 2025
@typescript-bot typescript-bot merged commit 28411e0 into DefinitelyTyped:master Jun 4, 2025
4 checks passed
@hkleungai hkleungai deleted the flatbuffers-removal branch June 4, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Edits Infrastructure Maintainer Approved No Other Owners This DT module only has one owner, so we can't have someone verify the change. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants