Skip to content

[telegram-web-app] add support for Bot API 9.1#74063

Merged
typescript-bot merged 5 commits intoDefinitelyTyped:masterfrom
sidorko:master
Nov 25, 2025
Merged

[telegram-web-app] add support for Bot API 9.1#74063
typescript-bot merged 5 commits intoDefinitelyTyped:masterfrom
sidorko:master

Conversation

@sidorko
Copy link
Copy Markdown
Contributor

@sidorko sidorko commented Nov 11, 2025

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change.
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run pnpm test telegram-web-app.
  • Provide a URL to documentation or source code which provides context for the suggested changes: Bot API 9.1
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Nov 11, 2025

@sidorko Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 74063,
  "author": "sidorko",
  "headCommitOid": "d44a9f5e77d5a981b460f43f10a172bae4d205d9",
  "mergeBaseOid": "7b5ba150354f32d8b5a849826aadb2c1bf538d12",
  "lastPushDate": "2025-11-11T16:50:57.000Z",
  "lastActivityDate": "2025-11-25T10:17:06.000Z",
  "mergeOfferDate": "2025-11-25T09:54:07.000Z",
  "mergeRequestDate": "2025-11-25T10:17:06.000Z",
  "mergeRequestUser": "sidorko",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "telegram-web-app",
      "kind": "edit",
      "files": [
        {
          "path": "types/telegram-web-app/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/telegram-web-app/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/telegram-web-app/telegram-web-app-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "KnorpelSenf",
        "MKRhere",
        "deptyped"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "KnorpelSenf",
      "date": "2025-11-25T09:53:24.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 3517855209,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @KnorpelSenf @MKRhere @deptyped — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Nov 11, 2025
@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Nov 22, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

Re-ping @KnorpelSenf, @MKRhere, @deptyped:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added The CI failed When GH Actions fails and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Nov 23, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

@sidorko The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in Pull Request Status Board Nov 23, 2025
@typescript-bot typescript-bot added Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. and removed The CI failed When GH Actions fails labels Nov 23, 2025
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in Pull Request Status Board Nov 23, 2025
@typescript-bot typescript-bot added The CI failed When GH Actions fails and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Nov 23, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in Pull Request Status Board Nov 23, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

@sidorko The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot added Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. and removed The CI failed When GH Actions fails labels Nov 23, 2025
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in Pull Request Status Board Nov 23, 2025
Copy link
Copy Markdown
Contributor

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit-pick, can be merged right after

Comment thread types/telegram-web-app/index.d.ts Outdated
*/
openInvoice(url: string, callback: (status: "paid" | "cancelled" | "failed" | "pending") => void): void;
/**
* Bot API 9.1+
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to keep the versions in here, but let's keep the formatting consistent then:

Suggested change
* Bot API 9.1+
* **Bot API 9.1+**

Copy link
Copy Markdown
Contributor Author

@sidorko sidorko Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KnorpelSenf
I am preparing more changes to the format, to use more features of the JS doc. What do you think about that?

  /**
   * *True*, if the Mini App is currently active.
   * *False*, if the Mini App is minimized.
   *
   * @since Bot API 8.0+
   */
  isActive: boolean;
/**
   * An object with input data transferred to the Mini App.
   *
   * **WARNING:** Data from this field should not be trusted.
   * You should only use data from {@link initData} on the bot's server and only after it has been {@link https://core.telegram.org/bots/webapps#validating-data-received-via-the-mini-app| validated}.
   */
  initDataUnsafe: WebAppInitData;

@typescript-bot typescript-bot added Revision needed This PR needs code changes before it can be merged. and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Nov 24, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in Pull Request Status Board Nov 24, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

@sidorko One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

Co-authored-by: KnorpelSenf <shtrog@gmail.com>
@typescript-bot typescript-bot added Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. and removed Revision needed This PR needs code changes before it can be merged. labels Nov 25, 2025
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in Pull Request Status Board Nov 25, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

@KnorpelSenf Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

Copy link
Copy Markdown
Contributor

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Nov 25, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in Pull Request Status Board Nov 25, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

@sidorko: Everything looks good here. I am ready to merge this PR (at d44a9f5) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@KnorpelSenf, @MKRhere, @deptyped: you can do this too.)

@sidorko
Copy link
Copy Markdown
Contributor Author

sidorko commented Nov 25, 2025

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Nov 25, 2025
@typescript-bot typescript-bot merged commit 10f9017 into DefinitelyTyped:master Nov 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants