[sparql-http-client] Add parameters to QueryOptions

[giacomoronconiobda]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run pnpm test <package to test>.

Select one of these and delete the others:

If adding a new definition:

• The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
• If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
• Create it with dts-gen --dt, not by basing it on an existing project.
• Represents shape of module/library correctly
• tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: <Added support for custom parameters rdf-ext/sparql-http-client#74>
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

If removing a declaration:

• If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
• Delete the package's directory.
• Add it to notNeededPackages.json.

[typescript-bot]

@giacomoronconiobda Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

1 package in this PR

• sparql-http-client — on npm, on unpkg
  • owner-approval: @tpluscode
  • 1 added owner: ✎@giacomoronconiobda

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 74107,
  "author": "giacomoronconiobda",
  "headCommitOid": "bdbf878ddb835f260da5c4549c47cefd249db210",
  "mergeBaseOid": "475cf15f3c61c8046fb2c1e7c744a4c09ac57b45",
  "lastPushDate": "2025-11-18T10:59:12.000Z",
  "lastActivityDate": "2025-11-19T09:54:57.000Z",
  "mergeOfferDate": "2025-11-19T09:54:40.000Z",
  "mergeRequestDate": "2025-11-19T09:54:57.000Z",
  "mergeRequestUser": "tpluscode",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "sparql-http-client",
      "kind": "edit",
      "files": [
        {
          "path": "types/sparql-http-client/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/sparql-http-client/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/sparql-http-client/sparql-http-client-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "tpluscode",
        "ludovicm67"
      ],
      "addedOwners": [
        "giacomoronconiobda"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "tpluscode",
      "date": "2025-11-19T09:53:59.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 3546953294,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @tpluscode @ludovicm67 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@giacomoronconiobda The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.

[tpluscode]

Hey, thank your this, and thank you even more for requesting the feature with the library author.

I see Thomas only added a very generic parametr but maybe it's a good idea to go one step further and include the default query params so that IDEs can make better suggestions, at the same time keeping the open-ended param map.

I think I will approve as-is and submit an extension to your work later.

However, first please ensure to add some tests so that we will be able to merge without the involvement of DT maintainers.

[typescript-bot]

@giacomoronconiobda One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

[typescript-bot]

@tpluscode Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[tpluscode]

Ah, so you went ahead with this. That's awesome, but I need to stop you here. ;)

I checked the spec, and the known params are different for queries and updates. Also, they are not defaultGraph and namedGraph. For query, it's default-graph-uri and named-graph-uri. For update, it's using-graph-uri and using-named-graph-uri.

I was planning to rename the QueryOptions to BaseQueryOptions and then sub-type QueryQueryOptions (yuk!) and UpdateQueryOptions, each with their respective named param names.

[giacomoronconiobda]

Yes probably it's better since they have different names for the update queries.

The default query parameters names are the one you mentioned but in the code of the implementation they used this camel case version. That's where I found them.

[giacomoronconiobda]

https://github.com/rdf-ext/sparql-http-client/blob/d5baa7e191659659b2e0eddda7946af09135cac5/RawQuery.js#L23

[tpluscode]

Hm, I see. So Thomas uses camel-case name and maps to the correct URL params. Slightly surprising maybe but os be it

[typescript-bot]

@giacomoronconiobda One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

[typescript-bot]

@tpluscode Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[tpluscode]

Now it's perfect 👍

[typescript-bot]

@giacomoronconiobda: Everything looks good here. I am ready to merge this PR (at bdbf878) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@tpluscode, @ludovicm67: you can do this too.)

[tpluscode]

Ready to merge