feat(chrome-remote-interface): update domain types to v0.33#74132
Conversation
|
@hkleungai Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 74132,
"author": "hkleungai",
"headCommitOid": "af8d8432cf21abb56e1232305c1019e0bd1d19ad",
"mergeBaseOid": "86f44b5ee78b2ea5c25b8deb9f6f5d846042cf56",
"lastPushDate": "2025-11-24T19:19:44.000Z",
"lastActivityDate": "2025-11-30T06:06:01.000Z",
"mergeOfferDate": "2025-11-30T06:01:18.000Z",
"mergeRequestDate": "2025-11-30T06:06:01.000Z",
"mergeRequestUser": "hkleungai",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "chrome-remote-interface",
"kind": "edit",
"files": [
{
"path": "types/chrome-remote-interface/chrome-remote-interface-tests.ts",
"kind": "test"
},
{
"path": "types/chrome-remote-interface/index.d.ts",
"kind": "definition"
},
{
"path": "types/chrome-remote-interface/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"kazarmy",
"westy92"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "kazarmy",
"date": "2025-11-30T06:00:38.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 3572351600,
"ciResult": "pass"
} |
|
🔔 @kazarmy @westy92 — please review this PR in the next few days. Be sure to explicitly select |
| method?: string | undefined; | ||
| params?: object | undefined; |
There was a problem hiding this comment.
Why are the method and params optional?
71ea55a to
af8d843
Compare
|
@kazarmy Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
| */ | ||
| Tethering: ProtocolProxyApi.TetheringApi; | ||
| /** @deprecated this API is experimental. */ | ||
| Tracing: ProtocolProxyApi.TracingApi; |
There was a problem hiding this comment.
As per https://chromedevtools.github.io/devtools-protocol/1-3/, Tracing should be considered stable. I also see some new experimental APIs at https://chromedevtools.github.io/devtools-protocol/tot/ (e.g. BluetoothEmulation) but I suppose https://github.com/cyrus-and/chrome-remote-interface/.../lib/protocol.json needs to be updated as well.
There was a problem hiding this comment.
I opened an issue few days ago on the source repo, but looks like library author has no intention to keep protocol json file up-to-date. 🤷♂️
There was a problem hiding this comment.
I would interpret cyrus-and/chrome-remote-interface#578 (comment) and https://github.com/cyrus-and/chrome-remote-interface/.../README.md#chrome-debugging-protocol-versions to mean that you can ignore the protocol.json file, but I think it would be nice if you can update it for him.
|
Ready to merge |
protocol.jsonis last updated inJul 29, 2023. See https://github.com/cyrus-and/chrome-remote-interface/commits/master/lib/protocol.json; The closest release ofdevtools-protocolto that date isv0.0.1173815, see ChromeDevTools/devtools-protocol@e22d6aa. Hence thedevtools-protocoldep is pinned to that specific version.With the package upgrade, certain changes are brought to
StableDomains&ExperimentalDomainsinterfaces. The updates are based onprotocol.json, with its"deprecated": true/"experimental": truemarking on each domain entry.Tests are added for (almost) fully covering
.on()events.Resolves discussion #74129.
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
package.json.