Skip to content

[xrm] Fix return type for Xrm.ProcessFlow.Stage.getSteps#74158

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
otressler:master
Nov 28, 2025
Merged

[xrm] Fix return type for Xrm.ProcessFlow.Stage.getSteps#74158
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
otressler:master

Conversation

@otressler
Copy link
Copy Markdown
Contributor

Please fill in this template.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Nov 28, 2025

@otressler Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 74158,
  "author": "otressler",
  "headCommitOid": "efd55c583c2550de3179f79699fa36752745b927",
  "mergeBaseOid": "28db5778b463f70540c98521df069357e0903081",
  "lastPushDate": "2025-11-28T11:29:07.000Z",
  "lastActivityDate": "2025-11-28T12:48:24.000Z",
  "mergeOfferDate": "2025-11-28T12:47:04.000Z",
  "mergeRequestDate": "2025-11-28T12:48:24.000Z",
  "mergeRequestUser": "daryllabar",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "xrm",
      "kind": "edit",
      "files": [
        {
          "path": "types/xrm/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/xrm/xrm-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "mattngan",
        "markusmauch",
        "daryllabar",
        "clownwilleatme",
        "scottdurow",
        "filcole",
        "power-maverick",
        "gncnpk"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "daryllabar",
      "date": "2025-11-28T12:46:24.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 3588975670,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @mattngan @markusmauch @daryllabar @clownwilleatme @scottdurow @filcole @Power-Maverick @gncnpk — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Nov 28, 2025
@DangerBotOSS
Copy link
Copy Markdown

Formatting

The following files are not formatted:

  1. types/xrm/xrm-tests.ts

Consider running pnpm dprint fmt on these files to make review easier.

Generated by 🚫 dangerJS against efd55c5

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Nov 28, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in Pull Request Status Board Nov 28, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

@otressler: Everything looks good here. I am ready to merge this PR (at efd55c5) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@mattngan, @markusmauch, @daryllabar, @clownwilleatme, @scottdurow, @filcole, @Power-Maverick, @gncnpk: you can do this too.)

@daryllabar
Copy link
Copy Markdown
Contributor

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Nov 28, 2025
@typescript-bot typescript-bot merged commit 8ee1a43 into DefinitelyTyped:master Nov 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants