Skip to content

[phoenix] Add authToken option to SocketConnectOption#74189

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
thisistonydang:thisistonydang/phoenix-authToken
Dec 8, 2025
Merged

[phoenix] Add authToken option to SocketConnectOption#74189
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
thisistonydang:thisistonydang/phoenix-authToken

Conversation

@thisistonydang
Copy link
Copy Markdown
Contributor

Please fill in this template.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Dec 8, 2025

@thisistonydang Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 74189,
  "author": "thisistonydang",
  "headCommitOid": "ed978c5e88f7c4c24c89f22c8acbba3bf3bfc602",
  "mergeBaseOid": "82f2ae816d39b0859a8aa116ad8400d6376c72fd",
  "lastPushDate": "2025-12-08T17:55:37.000Z",
  "lastActivityDate": "2025-12-08T21:52:52.000Z",
  "maintainerBlessed": "Waiting for Author to Merge (Blessed)",
  "mergeOfferDate": "2025-12-08T21:50:48.000Z",
  "mergeRequestDate": "2025-12-08T21:52:52.000Z",
  "mergeRequestUser": "thisistonydang",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "phoenix",
      "kind": "edit",
      "files": [
        {
          "path": "types/phoenix/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/phoenix/phoenix-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "mciastek",
        "John-Goff",
        "princemaple"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "princemaple",
      "date": "2025-12-08T21:50:08.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 3628310877,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @mciastek @John-Goff @princemaple — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Dec 8, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Dec 8, 2025
@sheetalkamat sheetalkamat moved this from Needs Maintainer Review to Waiting for Code Reviews (Blessed) in Pull Request Status Board Dec 8, 2025
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Dec 8, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

@thisistonydang: Everything looks good here. I am ready to merge this PR (at ed978c5) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@mciastek, @John-Goff, @princemaple: you can do this too.)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews (Blessed) to Waiting for Author to Merge (Blessed) in Pull Request Status Board Dec 8, 2025
@thisistonydang
Copy link
Copy Markdown
Contributor Author

Ready to merge

@typescript-bot typescript-bot merged commit b694df4 into DefinitelyTyped:master Dec 8, 2025
4 checks passed
@typescript-bot typescript-bot moved this from Waiting for Author to Merge (Blessed) to Recently Merged in Pull Request Status Board Dec 8, 2025
@thisistonydang thisistonydang deleted the thisistonydang/phoenix-authToken branch December 8, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Critical package Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants