Skip to content

Fix: Update types for VS Code 1.107 extension API#74198

Merged
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
lramos15:master
Dec 10, 2025
Merged

Fix: Update types for VS Code 1.107 extension API#74198
typescript-bot merged 2 commits intoDefinitelyTyped:masterfrom
lramos15:master

Conversation

@lramos15
Copy link
Copy Markdown
Contributor

No description provided.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Dec 10, 2025

@lramos15 Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 74198,
  "author": "lramos15",
  "headCommitOid": "21b4a64e1cf9b192097e6072e1928f602b4b1272",
  "mergeBaseOid": "45aa16796155f951c4ed6751bb81a7360bdc4fb7",
  "lastPushDate": "2025-12-10T19:25:56.000Z",
  "lastActivityDate": "2025-12-10T19:53:38.000Z",
  "maintainerBlessed": "Waiting for Author to Merge (Blessed)",
  "mergeOfferDate": "2025-12-10T19:35:18.000Z",
  "mergeRequestDate": "2025-12-10T19:53:38.000Z",
  "mergeRequestUser": "lramos15",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "vscode",
      "kind": "edit",
      "files": [
        {
          "path": "types/vscode/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/vscode/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "microsoft"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "sheetalkamat",
      "date": "2025-12-10T19:34:40.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 3638632059,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Copy Markdown
Contributor

Hey @lramos15,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @microsoft — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Dec 10, 2025
@sheetalkamat sheetalkamat moved this from Needs Maintainer Review to Waiting for Code Reviews (Blessed) in Pull Request Status Board Dec 10, 2025
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Dec 10, 2025
@typescript-bot
Copy link
Copy Markdown
Contributor

@lramos15: Everything looks good here. I am ready to merge this PR (at 21b4a64) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@microsoft: you can do this too.)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews (Blessed) to Waiting for Author to Merge (Blessed) in Pull Request Status Board Dec 10, 2025
@lramos15
Copy link
Copy Markdown
Contributor Author

Ready to merge

@typescript-bot typescript-bot merged commit 7f5f100 into DefinitelyTyped:master Dec 10, 2025
4 checks passed
@typescript-bot typescript-bot moved this from Waiting for Author to Merge (Blessed) to Recently Merged in Pull Request Status Board Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Critical package Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants