Skip to content

Conversation

@paulinagacek
Copy link
Contributor

Context

This PR creates a new package to provide type definitions for Capture All Screens API in line with the specification. Capture All Screens is a part of Isolated Web App APIs.

IWA Explainer: https://github.com/WICG/isolated-web-apps

Motivation

Currently, TypeScript has no knowledge of these IWA-specific APIs. This leads to:

  • Lack of Type Safety: Developers are forced to use any or incomplete local interface merging.
  • Poor Developer Experience: No autocomplete or inline documentation for these APIs in editors.
  • Maintenance Overhead: Projects (like the official IWA Sink) currently rely on hardcoded types that drift out of sync with the implementation.

@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 12, 2025

@paulinagacek Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes when there are new packages added

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 74211,
  "author": "paulinagacek",
  "headCommitOid": "1fc3cc1ea4bbc586ceaa9d7baa61e166f59ea017",
  "mergeBaseOid": "c50862c2aee7eb160ca6632d089227c20587eb71",
  "lastPushDate": "2025-12-12T16:43:50.000Z",
  "lastActivityDate": "2026-01-13T06:00:56.000Z",
  "mergeOfferDate": "2026-01-12T21:30:52.000Z",
  "mergeRequestDate": "2026-01-13T06:00:56.000Z",
  "mergeRequestUser": "paulinagacek",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "w3c-capture-all-screens",
      "kind": "add",
      "files": [
        {
          "path": "types/w3c-capture-all-screens/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/w3c-capture-all-screens/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/w3c-capture-all-screens/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/w3c-capture-all-screens/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/w3c-capture-all-screens/w3c-capture-all-screens-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [],
      "addedOwners": [
        "paulinagacek",
        "GrapeGreen",
        "shangl"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2026-01-12T21:30:13.000Z",
      "isMaintainer": true
    },
    {
      "type": "stale",
      "reviewer": "GrapeGreen",
      "date": "2025-12-12T16:50:53.000Z",
      "abbrOid": "200ed26"
    }
  ],
  "mainBotCommentID": 3647329897,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the New Definition This PR creates a new definition package. label Dec 12, 2025
@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Dec 12, 2025
@typescript-bot
Copy link
Contributor

🔔 @paulinagacek — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in Pull Request Status Board Dec 12, 2025
@typescript-bot typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label Dec 12, 2025
@paulinagacek
Copy link
Contributor Author

@sheetalkamat could you please take a look? :)

@paulinagacek
Copy link
Contributor Author

@jakebailey could you please take a look? 🙏🏼 🥺

@paulinagacek
Copy link
Contributor Author

@jakebailey could you please take a look? 🙏🏼 🥺

@jakebailey I cannot merge this PR without maintainer approval, I think this PR somehow got lost in your dashboard. I would be extremely grateful if you could take a look, thanks!

@typescript-bot
Copy link
Contributor

Re-ping @«anyone?»:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Dec 23, 2025
@paulinagacek
Copy link
Contributor Author

@sheetalkamat @jakebailey kind reminder

@typescript-bot
Copy link
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @paulinagacek.

(Ping @«anyone?».)

}
}

export interface ScreenDetailed extends Screen {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package is not intended to be imported as w3c-capture-all-screens; why does it have an export? Shouldn't it be entirely globals?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, thank you! Fixed. I've removed the exports and the declare global wrappers. The definitions are now entirely global, and I've updated the tests to reflect this (no imports required).

@typescript-bot typescript-bot removed the Other Approved This PR was reviewed and signed-off by a community member. label Jan 11, 2026
@typescript-bot
Copy link
Contributor

@jakebailey, @GrapeGreen Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Jan 12, 2026
@typescript-bot
Copy link
Contributor

@paulinagacek: Everything looks good here. I am ready to merge this PR (at 1fc3cc1) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in Pull Request Status Board Jan 12, 2026
@typescript-bot
Copy link
Contributor

@GrapeGreen Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@paulinagacek
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Jan 13, 2026
@typescript-bot typescript-bot merged commit 49a2604 into DefinitelyTyped:master Jan 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Approved New Definition This PR creates a new definition package. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

Status: Recently Merged

Development

Successfully merging this pull request may close these issues.

4 participants