Skip to content

[aws-cloudfront-function] fix: make kvsId optional in kvs()#74676

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
y-hsgw:fix/kvs-optional-types
Mar 13, 2026
Merged

[aws-cloudfront-function] fix: make kvsId optional in kvs()#74676
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
y-hsgw:fix/kvs-optional-types

Conversation

@y-hsgw
Copy link
Contributor

@y-hsgw y-hsgw commented Mar 12, 2026

Fixes: #73959

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 12, 2026

@y-hsgw Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 74676,
  "author": "y-hsgw",
  "headCommitOid": "0e49bc62dbe240ead56ab4394b7f87b739c03dcb",
  "mergeBaseOid": "1e61bc5e872ac817652ae8625a8d21abe8ba94fc",
  "lastPushDate": "2026-03-12T07:05:14.000Z",
  "lastActivityDate": "2026-03-13T23:14:49.000Z",
  "mergeOfferDate": "2026-03-13T18:52:53.000Z",
  "mergeRequestDate": "2026-03-13T23:14:49.000Z",
  "mergeRequestUser": "y-hsgw",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "aws-cloudfront-function",
      "kind": "edit",
      "files": [
        {
          "path": "types/aws-cloudfront-function/aws-cloudfront-function-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/aws-cloudfront-function/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "bukka"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "bukka",
      "date": "2026-03-13T18:52:13.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 4044471536,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @bukka — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Mar 12, 2026
@y-hsgw y-hsgw changed the title [aws-cloudfront-function] fix: make kvsId optional in kvs() and update tests [aws-cloudfront-function] fix: make kvsId optional in kvs() Mar 12, 2026
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Mar 13, 2026
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in Pull Request Status Board Mar 13, 2026
@typescript-bot
Copy link
Contributor

@y-hsgw: Everything looks good here. I am ready to merge this PR (at 0e49bc6) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@bukka: you can do this too.)

@y-hsgw
Copy link
Contributor Author

y-hsgw commented Mar 13, 2026

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Mar 13, 2026
@typescript-bot typescript-bot merged commit d377e9e into DefinitelyTyped:master Mar 13, 2026
4 checks passed
@y-hsgw y-hsgw deleted the fix/kvs-optional-types branch March 13, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

Status: Recently Merged

Development

Successfully merging this pull request may close these issues.

[@types/aws-cloudfront-function] 'cf.kvs()' should not require an argument

3 participants