[mapbox__mapbox-sdk] Fix GeocodeV6Request.proximity type#74803
[mapbox__mapbox-sdk] Fix GeocodeV6Request.proximity type#74803ricardohsweiss wants to merge 2 commits intoDefinitelyTyped:masterfrom
Conversation
|
@ricardohsweiss Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 10 days. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 74803,
"author": "ricardohsweiss",
"headCommitOid": "d6f30841e94815f3308ddc48d16bd56246c0e80f",
"mergeBaseOid": "b18c0e77059402c2fd62a7483e00dfd2209bf776",
"lastPushDate": "2026-03-26T15:32:42.000Z",
"lastActivityDate": "2026-03-26T15:32:42.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "mapbox__mapbox-sdk",
"kind": "edit",
"files": [
{
"path": "types/mapbox__mapbox-sdk/index.d.ts",
"kind": "definition"
},
{
"path": "types/mapbox__mapbox-sdk/mapbox__mapbox-sdk-tests.ts",
"kind": "test"
}
],
"owners": [
"jeffbdye",
"mikeomeara1",
"chachan",
"techieshark",
"rroohhh"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [],
"mainBotCommentID": 4136012792,
"ciResult": "pass"
} |
|
🔔 @jeffbdye @mikeomeara1 @chachan @techieshark @rroohhh — please review this PR in the next few days. Be sure to explicitly select |
Please fill in this template.
pnpm test mapbox__mapbox-sdk.If changing an existing definition:
package.json.Summary
In
@mapbox/mapbox-sdk/services/geocoding-v6,GeocodeV6Request.proximityis currently typed asCoordinates | "ip"whereCoordinatesresolves to an object shape ({ longitude, latitude, ... }) in this module.At runtime,
proximityaccepts coordinate tuples ([longitude, latitude]) or"ip". This mismatch causes incorrect TypeScript errors for valid usage and forces downstream casts.This PR updates the type to use
MapiRequestCoordinates | "ip"forGeocodeV6Request.proximity, aligning the v6 request type with runtime behavior and the existing imported tuple coordinate type.