Skip to content

[three] Fix isType properties#74932

Open
Methuselah96 wants to merge 2 commits intoDefinitelyTyped:masterfrom
three-types:three-fix-is
Open

[three] Fix isType properties#74932
Methuselah96 wants to merge 2 commits intoDefinitelyTyped:masterfrom
three-types:three-fix-is

Conversation

@Methuselah96
Copy link
Copy Markdown
Contributor

Fixes a bug in #74890, ported from three-types/three-ts-types#2129

Please fill in this template.

If changing an existing definition:

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 29, 2026

@Methuselah96 Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 74932,
  "author": "Methuselah96",
  "headCommitOid": "957d3401fe16235e2706042a1987c9b8f9aff40f",
  "mergeBaseOid": "366ba8451fd37ac011c83c8f4dce1036c99cd53a",
  "lastPushDate": "2026-04-29T12:23:28.000Z",
  "lastActivityDate": "2026-04-29T12:23:28.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "three",
      "kind": "edit",
      "files": [
        {
          "path": "types/three/src/math/Matrix2.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/math/Matrix3.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/math/Matrix4.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/math/Vector2.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/math/Vector3.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/src/math/Vector4.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/three/test/unit/src/math/Vector3.ts",
          "kind": "test"
        },
        {
          "path": "types/three/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "joshuaellis",
        "Methuselah96"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 4343951419,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Author is Owner The author of this PR is a listed owner of the package. Untested Change This PR does not touch tests labels Apr 29, 2026
@typescript-bot typescript-bot moved this to Needs Maintainer Review in Pull Request Status Board Apr 29, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @joshuaellis — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot removed the Untested Change This PR does not touch tests label Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. Critical package

Projects

Status: Needs Maintainer Review

Development

Successfully merging this pull request may close these issues.

2 participants