Update chance types to be module-first, global-second#74939
Update chance types to be module-first, global-second#74939typescript-bot merged 4 commits intoDefinitelyTyped:masterfrom
Conversation
|
@chriskrycho Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PR
Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 74939,
"author": "chriskrycho",
"headCommitOid": "e0d9063cd529eb4353dcbf6e29ea3491657f7f72",
"mergeBaseOid": "de9d7a2a0f0fa222ad71babffd3144df176d3410",
"lastPushDate": "2026-04-30T21:46:17.000Z",
"lastActivityDate": "2026-05-01T18:28:56.000Z",
"mergeOfferDate": "2026-05-01T13:36:56.000Z",
"mergeRequestDate": "2026-05-01T18:28:56.000Z",
"mergeRequestUser": "chriskrycho",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"tooManyCommits": false,
"tooManyReviews": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "chance",
"kind": "edit",
"files": [
{
"path": "types/chance/chance-tests.ts",
"kind": "test"
},
{
"path": "types/chance/index.d.ts",
"kind": "definition"
}
],
"owners": [
"cbowdon",
"brikou",
"cafesanu",
"colbywhite",
"NewDark90",
"jacobez",
"peterblazejewicz"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "colbywhite",
"date": "2026-05-01T13:36:17.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 4356375240,
"ciResult": "pass"
} |
|
🔔 @cbowdon @brikou @cafesanu @colbywhite @NewDark90 @jacobez @peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select |
def5cd0 to
9c57478
Compare
|
@chriskrycho The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
These were not new, but they're being flagged as new by dint of the change, and it's great to get them fix.ed
|
@chriskrycho: Everything looks good here. I am ready to merge this PR (at e0d9063) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@cbowdon, @brikou, @cafesanu, @colbywhite, @NewDark90, @jacobez, @peterblazejewicz: you can do this too.) |
|
Ready to merge |
This maintains the existing API contract; it simply “inverts” how it is accomplished, and makes it much easier to name specific types from the package and in particular makes it possible to name the
Chanceinstance type without relying on the global being visible in the types.Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
package.json.