Skip to content

[navermaps] Mark GL-only methods as optional on StreetLayer#75003

Merged
typescript-bot merged 1 commit into
DefinitelyTyped:masterfrom
kkokkojeong:navermaps-gl-optional-methods
May 15, 2026
Merged

[navermaps] Mark GL-only methods as optional on StreetLayer#75003
typescript-bot merged 1 commit into
DefinitelyTyped:masterfrom
kkokkojeong:navermaps-gl-optional-methods

Conversation

@kkokkojeong
Copy link
Copy Markdown
Contributor

@kkokkojeong kkokkojeong commented May 15, 2026

Summary

StreetLayer.setAirWaterView and StreetLayer.isVisibleAirWaterView are only available in the NAVER Maps GL submodule, not in the standard Maps JS API.
Marking them as optional so consumers using the non-GL build are not forced to call (or assume the existence of) methods that do not exist at runtime.

If changing an existing definition:

setAirWaterView and isVisibleAirWaterView are only available in the
Maps GL submodule, so mark them optional on StreetLayer.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented May 15, 2026

@kkokkojeong Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 75003,
  "author": "kkokkojeong",
  "headCommitOid": "cc1105065a21b1d0672d841166c2a4a29643e631",
  "mergeBaseOid": "3c8407903130ad6ac2dca5af44bffc0ffad64d6e",
  "lastPushDate": "2026-05-15T01:56:49.000Z",
  "lastActivityDate": "2026-05-15T02:09:42.000Z",
  "mergeOfferDate": "2026-05-15T02:03:50.000Z",
  "mergeRequestDate": "2026-05-15T02:09:42.000Z",
  "mergeRequestUser": "kkokkojeong",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "navermaps",
      "kind": "edit",
      "files": [
        {
          "path": "types/navermaps/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/navermaps/navermaps-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "ckboyjiy",
        "DongKyuuuu",
        "fclemonschool",
        "suhwancha",
        "hig4342",
        "kkokkojeong",
        "gseok"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "gseok",
      "date": "2026-05-15T02:00:03.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 4456220751,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Author is Owner The author of this PR is a listed owner of the package. label May 15, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @ckboyjiy @Dongkyuuuu @fclemonschool @SuhwanCha @hig4342 @gseok — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board May 15, 2026
Copy link
Copy Markdown
Contributor

@gseok gseok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels May 15, 2026
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in Pull Request Status Board May 15, 2026
@typescript-bot
Copy link
Copy Markdown
Contributor

@kkokkojeong: Everything looks good here. I am ready to merge this PR (at cc11050) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@ckboyjiy, @Dongkyuuuu, @fclemonschool, @SuhwanCha, @hig4342, @gseok: you can do this too.)

@kkokkojeong
Copy link
Copy Markdown
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board May 15, 2026
@typescript-bot typescript-bot merged commit 2266eb2 into DefinitelyTyped:master May 15, 2026
4 checks passed
@kkokkojeong kkokkojeong deleted the navermaps-gl-optional-methods branch May 15, 2026 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

Status: Recently Merged

Development

Successfully merging this pull request may close these issues.

3 participants