[navermaps] Mark GL-only methods as optional on StreetLayer#75003
Conversation
setAirWaterView and isVisibleAirWaterView are only available in the Maps GL submodule, so mark them optional on StreetLayer. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
@kkokkojeong Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 75003,
"author": "kkokkojeong",
"headCommitOid": "cc1105065a21b1d0672d841166c2a4a29643e631",
"mergeBaseOid": "3c8407903130ad6ac2dca5af44bffc0ffad64d6e",
"lastPushDate": "2026-05-15T01:56:49.000Z",
"lastActivityDate": "2026-05-15T02:09:42.000Z",
"mergeOfferDate": "2026-05-15T02:03:50.000Z",
"mergeRequestDate": "2026-05-15T02:09:42.000Z",
"mergeRequestUser": "kkokkojeong",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"tooManyCommits": false,
"tooManyReviews": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "navermaps",
"kind": "edit",
"files": [
{
"path": "types/navermaps/index.d.ts",
"kind": "definition"
},
{
"path": "types/navermaps/navermaps-tests.ts",
"kind": "test"
}
],
"owners": [
"ckboyjiy",
"DongKyuuuu",
"fclemonschool",
"suhwancha",
"hig4342",
"kkokkojeong",
"gseok"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "gseok",
"date": "2026-05-15T02:00:03.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 4456220751,
"ciResult": "pass"
} |
|
🔔 @ckboyjiy @Dongkyuuuu @fclemonschool @SuhwanCha @hig4342 @gseok — please review this PR in the next few days. Be sure to explicitly select |
|
@kkokkojeong: Everything looks good here. I am ready to merge this PR (at cc11050) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@ckboyjiy, @Dongkyuuuu, @fclemonschool, @SuhwanCha, @hig4342, @gseok: you can do this too.) |
|
Ready to merge |
Summary
StreetLayer.setAirWaterViewandStreetLayer.isVisibleAirWaterVieware only available in the NAVER Maps GL submodule, not in the standard Maps JS API.Marking them as optional so consumers using the non-GL build are not forced to call (or assume the existence of) methods that do not exist at runtime.
pnpm test <package to test>.If changing an existing definition:
package.json.