Skip to content

Issue #1797 fix api generate index array#1798

Merged
JoerivanEngelen merged 6 commits intomasterfrom
issue_#1797_fix_api_generate_index_array
Mar 31, 2026
Merged

Issue #1797 fix api generate index array#1798
JoerivanEngelen merged 6 commits intomasterfrom
issue_#1797_fix_api_generate_index_array

Conversation

@JoerivanEngelen
Copy link
Copy Markdown
Contributor

@JoerivanEngelen JoerivanEngelen commented Mar 30, 2026

Fixes #1797

Description

This PR changes the following:

  • Fix so that public API method GridData.generate_index_array returns the same as it did in iMOD Python 1.0, throw DeprecationWarning urging users to update to GridData.generate_isactive_svat_array.
  • Further improve new name method to GridData.generate_isactive_svat_array and add it to public API docs
  • Refactor methods in GridData somewhat, to reduce code duplication.
  • Start renaming the unfortunately chosen variable name index to the more descriptive isactive, as the variable is in fact NOT an index. In a further PR we can rename this variable throughout the complete MetaSWAP module, which will affect a lot of files. I think that is worthy a separate PR.

Checklist

  • Links to correct issue
  • Update changelog, if changes affect users
  • PR title starts with Issue #nr, e.g. Issue #737
  • Unit tests were added
  • If feature added: Added/extended example
  • If feature added: Added feature to API documentation
  • If pixi.lock was changed: Ran pixi run generate-sbom and committed changes

@sonarqubecloud
Copy link
Copy Markdown

@JoerivanEngelen JoerivanEngelen added this pull request to the merge queue Mar 31, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 31, 2026
@JoerivanEngelen JoerivanEngelen merged commit 9a9f9db into master Mar 31, 2026
7 of 8 checks passed
@JoerivanEngelen JoerivanEngelen deleted the issue_#1797_fix_api_generate_index_array branch March 31, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revert breaking change to public API method generate_index_array

2 participants