-
Notifications
You must be signed in to change notification settings - Fork 17
fix processing #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix processing #210
Conversation
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 113 files out of 221 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Hi ! Thank you for contributing to Dembrane ECHO! Before we consider your Pull Request, we ask that you sign our Contributor License Agreement (CLA). This is only required for your first Pull Request. Please review the CLA, and sign it by adding your GitHub username to the contributors.yml file. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Test Assertion Error: Incorrect `pytest.approx()` Usage
Incorrect usage of pytest.approx() in the test_get_size method. The expected value (48.7 * 1024) is mistakenly passed as a tolerance parameter to pytest.approx(), leading to incorrect assertion logic. The correct usage should be assert size == pytest.approx(48.7 * 1024).
echo/server/tests/service/test_file_service.py#L53-L54
echo/echo/server/tests/service/test_file_service.py
Lines 53 to 54 in b01113e
| logger.info(f"size: {size}") | |
| assert pytest.approx(size, 48.7 * 1024) == 48.7 * 1024 |
Was this report helpful? Give feedback by reacting with 👍 or 👎
* update * wip * changes * add models * fix type errors
dev ex: